Merge lp:~jbicha/unity-settings-daemon/fix-ftbfs into lp:unity-settings-daemon

Proposed by Jeremy Bicha on 2017-03-22
Status: Merged
Approved by: Robert Ancell on 2017-03-22
Approved revision: 4157
Merged at revision: 4158
Proposed branch: lp:~jbicha/unity-settings-daemon/fix-ftbfs
Merge into: lp:unity-settings-daemon
Diff against target: 79 lines (+39/-23)
2 files modified
autogen.sh (+38/-23)
configure.ac (+1/-0)
To merge this branch: bzr merge lp:~jbicha/unity-settings-daemon/fix-ftbfs
Reviewer Review Type Date Requested Status
Robert Ancell 2017-03-22 Approve on 2017-03-22
Review via email: mp+320665@code.launchpad.net

Commit Message

Drop dependency on gnome-common to fix FTBFS (backported from gnome-settings-daemon)

To post a comment you must log in.
Robert Ancell (robert-ancell) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autogen.sh'
2--- autogen.sh 2013-12-04 23:55:26 +0000
3+++ autogen.sh 2017-03-22 16:14:40 +0000
4@@ -1,25 +1,40 @@
5 #!/bin/sh
6 # Run this to generate all the initial makefiles, etc.
7-
8-REQUIRED_AUTOMAKE_VERSION=1.5
9-USE_GNOME2_MACROS=1
10-
11-srcdir=`dirname $0`
12-test -z "$srcdir" && srcdir=.
13-
14-PKG_NAME="unity-settings-daemon"
15-
16-(test -f $srcdir/configure.ac \
17- && test -d $srcdir/gnome-settings-daemon \
18- && test -f $srcdir/gnome-settings-daemon/gnome-settings-manager.h) || {
19- echo -n "**Error**: Directory "\`$srcdir\'" does not look like the"
20- echo " top-level unity-settings-daemon directory"
21- exit 1
22-}
23-
24-which gnome-autogen.sh || {
25- echo "You need to install gnome-common from the GNOME SVN"
26- exit 1
27-}
28-
29-. gnome-autogen.sh
30+test -n "$srcdir" || srcdir=$(dirname "$0")
31+test -n "$srcdir" || srcdir=.
32+
33+olddir=$(pwd)
34+
35+cd $srcdir
36+
37+(test -f configure.ac) || {
38+ echo "*** ERROR: Directory '$srcdir' does not look like the top-level project directory ***"
39+ exit 1
40+}
41+
42+# shellcheck disable=SC2016
43+PKG_NAME=$(autoconf --trace 'AC_INIT:$1' configure.ac)
44+
45+if [ "$#" = 0 -a "x$NOCONFIGURE" = "x" ]; then
46+ echo "*** WARNING: I am going to run 'configure' with no arguments." >&2
47+ echo "*** If you wish to pass any to it, please specify them on the" >&2
48+ echo "*** '$0' command line." >&2
49+ echo "" >&2
50+fi
51+
52+aclocal --install || exit 1
53+glib-gettextize --force --copy || exit 1
54+intltoolize --force --copy --automake || exit 1
55+autoreconf --verbose --force --install || exit 1
56+
57+cd "$olddir"
58+if [ "$NOCONFIGURE" = "" ]; then
59+ $srcdir/configure "$@" || exit 1
60+
61+ if [ "$1" = "--help" ]; then exit 0 else
62+ echo "Now type 'make' to compile $PKG_NAME" || exit 1
63+ fi
64+else
65+ echo "Skipping configure process."
66+fi
67+
68
69=== modified file 'configure.ac'
70--- configure.ac 2016-05-15 01:00:17 +0000
71+++ configure.ac 2017-03-22 16:14:40 +0000
72@@ -4,6 +4,7 @@
73 [1.0])
74
75 AC_CONFIG_SRCDIR([gnome-settings-daemon/gnome-settings-manager.c])
76+AC_CONFIG_MACRO_DIR([m4])
77
78 AM_INIT_AUTOMAKE([1.9 tar-ustar dist-xz no-dist-gzip check-news])
79 AM_MAINTAINER_MODE([enable])

Subscribers

People subscribed via source and target branches