Merge lp:~jbicha/unity-lens-video/build-with-valac into lp:unity-lens-video

Proposed by Jeremy Bicha
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 117
Merged at revision: 119
Proposed branch: lp:~jbicha/unity-lens-video/build-with-valac
Merge into: lp:unity-lens-video
Diff against target: 12 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp:~jbicha/unity-lens-video/build-with-valac
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski Approve
Review via email: mp+168199@code.launchpad.net

Commit message

Build with default valac

Description of the change

This changes unity-lens-video to build against the default valac (for Ubuntu 13.10 this is currently valac 0.18 but we may switch to 0.20 as Debian testing already has). I have successfully test-built against valac-0.20.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

For some reason it fails for me if I only have valac-0.20.1 (the current one in S), and uninstall valac-0.18:

saucy:/home/pawel/src/ubuntu/unity-lens-videos/build-with-valac% dpkg-buildpackage -us -uc -b -j5
dpkg-buildpackage: source package unity-lens-video
dpkg-buildpackage: source version 0.3.15daily13.06.21-0ubuntu1
dpkg-buildpackage: source changed by Ubuntu daily release <email address hidden>
dpkg-buildpackage: host architecture amd64
 dpkg-source --before-build build-with-valac
dpkg-checkbuilddeps: Unmet build dependencies: valac (>= 0.18)
dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting
dpkg-buildpackage: warning: (Use -d flag to override.)
saucy:/home/pawel/src/ubuntu/unity-lens-videos/build-with-valac% valac --version
Vala 0.20.1

and btw, you'll need to merge trunk changes to fix issue with Gee.

review: Needs Fixing
Revision history for this message
Jeremy Bicha (jbicha) wrote :

No, it builds fine in a clean chroot. There is a package named "valac" that you need to have installed, not just valac-0.20.

My branch also merges into trunk without a problem.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

You're right, I got confused. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-05-16 16:51:18 +0000
3+++ debian/control 2013-06-07 21:34:31 +0000
4@@ -13,7 +13,7 @@
5 libsoup-gnome2.4-dev,
6 libunity-dev (>= 7.0.0),
7 libzeitgeist-dev (>= 0.3.8),
8- valac-0.18,
9+ valac (>= 0.18),
10 xvfb,
11 Standards-Version: 3.9.4
12 Homepage: https://launchpad.net/unity-lens-video

Subscribers

People subscribed via source and target branches