Merge lp:~jbicha/ubuntu/oneiric/debian-gis/fix-nbs-depends into lp:ubuntu/oneiric/debian-gis

Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 2
Proposed branch: lp:~jbicha/ubuntu/oneiric/debian-gis/fix-nbs-depends
Merge into: lp:ubuntu/oneiric/debian-gis
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
tasks/osm (+1/-1)
To merge this branch: bzr merge lp:~jbicha/ubuntu/oneiric/debian-gis/fix-nbs-depends
Reviewer Review Type Date Requested Status
Michael Terry Approve
Review via email: mp+72701@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

A couple comments:

1) It looks like maptool is already in tasks/osm (the line above the one you changed). So maybe simply remove osm2navit.

2) This patch should be sent to Debian too.

3) Is this actively causing a problem, or just installing an unnecessary package? If the latter, I think we can wait for Debian to fix it rather than introduce a delta.

review: Needs Fixing
Revision history for this message
Colin Watson (cjwatson) wrote :

On Mon, Aug 29, 2011 at 04:21:23PM -0000, Michael Terry wrote:
> 3) Is this actively causing a problem, or just installing an
> unnecessary package? If the latter, I think we can wait for Debian to
> fix it rather than introduce a delta.

At this point, I think everything listed in
http://people.canonical.com/~ubuntu-archive/nbs.html should be
considered a problem that we need to fix now rather than waiting for
Debian.

Revision history for this message
Michael Terry (mterry) wrote :

OK. I've uploaded a version that also removes the other references to osm2navit (Recommends in debian/control and a reference in debian-gis-tasks.desc). And I updated the Maintainer field.

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

(and I forwarded to Debian)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-07-07 11:09:05 +0000
3+++ debian/changelog 2011-08-24 11:28:31 +0000
4@@ -1,3 +1,9 @@
5+debian-gis (0.0.1ubuntu1) oneiric; urgency=low
6+
7+ * Use maptool as replacement for osm2navit
8+
9+ -- Jeremy Bicha <jbicha@ubuntu.com> Wed, 24 Aug 2011 07:24:58 -0400
10+
11 debian-gis (0.0.1) unstable; urgency=low
12
13 * Initial release. (Closes: #587856)
14
15=== modified file 'tasks/osm'
16--- tasks/osm 2010-07-07 11:09:05 +0000
17+++ tasks/osm 2011-08-24 11:28:31 +0000
18@@ -19,7 +19,7 @@
19
20 Depends: maptool
21
22-Depends: osm2navit, osm2pgsql
23+Depends: maptool, osm2pgsql
24
25 X-Comment: Does it make sense to create a osm-server task???
26 Depends: osmosis

Subscribers

People subscribed via source and target branches

to all changes: