Code review comment for lp:~jbicha/ubiquity/update-updates-page

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks Jeremy and Rik for your work.

It all looks goo to me. I tested on Ubuntu, Kubuntu and Kylin and didn't find any issue.

Although the telemetry file generated for Kubuntu is not fully useful due to the name of the stages. Several steps are called "Form" or "page" without any indication of which form or page.

{
  "Media": "Kubuntu 18.04 LTS \"Bionic Beaver\" - Alpha amd64 (20180328)",
  "Type": "KDE",
  "PartitionMethod": "use_device",
  "DownloadUpdates": false,
  "Language": "en",
  "Minimal": true,
  "RestrictedAddons": true,
  "Stages": {
    "0": "language",
    "1": "language",
    "6": "page",
    "9": "Form",
    "44": "Form",
    "58": "start_install",
    "60": "page",
    "62": "Form",
    "73": "user_done",
    "785": "done"
  }
}

Approved! Thanks again!

review: Approve

« Back to merge proposal