Code review comment for lp:~jbicha/testdrive/port-to-gtk3

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hi Jeremy,

Sorry for the delay but just had the chance to review this change.

Now, overall everything looks good. I have fixed the bug on which the "Add ISO" option was disabled, now it should work. Fix is in trunk. This leads me to line 211 of AddOtherTestdrivegtkDialog.py. The only problem I see is that it's not actually displaying the ISO's that are added into the list store which leads me to believe that such line served for that purpose (haven't touch GTK since I initially wrote this part :)). If you find a solution would be great.

The Notification does not seem to be working but I was planning to disable momentarily.

Cheers.

review: Needs Fixing

« Back to merge proposal