Merge lp:~jbicha/onboard/dont-autostart-in-gshell into lp:~onboard/onboard/main

Proposed by Jeremy Bícha
Status: Rejected
Rejected by: marmuta
Proposed branch: lp:~jbicha/onboard/dont-autostart-in-gshell
Merge into: lp:~onboard/onboard/main
Diff against target: 11 lines (+1/-0)
1 file modified
data/onboard-autostart.desktop (+1/-0)
To merge this branch: bzr merge lp:~jbicha/onboard/dont-autostart-in-gshell
Reviewer Review Type Date Requested Status
Jeremy Bícha (community) Needs Fixing
Onboard Devel Team Pending
Review via email: mp+76890@code.launchpad.net

Description of the change

This prevents onboard from conflicting with GNOME Shell's built-in screen keyboard. This change should be made to the 0.95 branch too. Thanks!

To post a comment you must log in.
368. By Jeremy Bícha

Disable autostart in GNOME Shell since it has a built-in onscreen
keyboard

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Actually, this doesn't work. Only the first AutostartCondition is being used. GNOME Shell & GNOME Fallback should use different XDG_CURRENT_DESKTOP values instead of the "unless-session" hack. For Oneiric, I guess screen keyboard users will have to just manually close onboard (which is easy to do).

review: Needs Fixing
Revision history for this message
marmuta (marmuta) wrote :

Ok, thanks for the heads-up.

Revision history for this message
marmuta (marmuta) wrote :

Thanks for looking into this Jeremy. Since bug #879942 has a possible fix now, I'll close this proposal. If there are still problems we'll try again.

Unmerged revisions

368. By Jeremy Bícha

Disable autostart in GNOME Shell since it has a built-in onscreen
keyboard

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/onboard-autostart.desktop'
2--- data/onboard-autostart.desktop 2011-08-28 19:47:29 +0000
3+++ data/onboard-autostart.desktop 2011-09-25 17:26:22 +0000
4@@ -4,6 +4,7 @@
5 Type=Application
6 NoDisplay=true
7 X-Ubuntu-Gettext-Domain=onboard
8+AutostartCondition=GNOME3 unless-session gnome
9 AutostartCondition=GSettings org.gnome.desktop.a11y.applications screen-keyboard-enabled
10 X-GNOME-AutoRestart=true
11 OnlyShowIn=GNOME;Unity;

Subscribers

People subscribed via source and target branches

to status/vote changes: