Merge ~jbicha/network-manager:master into network-manager:master

Proposed by Jeremy Bicha on 2017-02-22
Status: Rejected
Rejected by: Jeremy Bicha on 2017-08-27
Proposed branch: ~jbicha/network-manager:master
Merge into: network-manager:master
Diff against target: 64 lines (+29/-0)
4 files modified
debian/20-connectivity.conf (+3/-0)
debian/changelog (+9/-0)
debian/control (+16/-0)
debian/network-manager-config-connectivity.install (+1/-0)
Reviewer Review Type Date Requested Status
Aron Xu 2017-02-22 Needs Information on 2017-02-23
Review via email: mp+318031@code.launchpad.net

Description of the change

By adding a separate package for this config snippet, it enables Ubuntu flavors to easily opt into the NetworkManager connectivity status check by recommending this package. Ubuntu users can easily override the default by installing or uninstalling this package.

I will be proposing this for zesty Feature Freeze Exception and I will bring it up for discussion on the ubuntu-devel list, so let's wait to merge until we get approval.

To post a comment you must log in.
Matteo Croce (teknoraver) :
Aron Xu (happyaron) wrote :

I have a few questions:

1. Whether the 5-minute checks will congest Canonical's web servers? Or local network operators may see a lot of Ubuntu desktops flooding the same request so frequently.

2. How to deal with caches? Google uses HTTPS + 204 response code, and Apple uses HTTPS + text file. The approach we are using is more likely to the latter one, but it does not support HTTPS.

review: Needs Information
Jeremy Bicha (jbicha) wrote :

Aron, could you ask someone in Canonical's web development about your first question?

I think this will have zero affect on other network operators. (All the other major operating systems do basically the same thing and almost anything else that uses the web will have a bigger effect.)

I don't know anything about #2. I think generally these network-connectivity-check URLs use http because there are problems with trying to ping a https server with a captive portal.

Also, could you maybe bring up your concerns on the ubuntu-devel list thread I started so that more people will see?

Jeremy Bicha (jbicha) wrote :

There are many other URIs that work. Some I know of are:

http://network-test.debian.org/nm
http://nmcheck.gnome.org/check_network_status.txt
http://fedoraproject.org/static/hotspot.txt (redirects to HTTPS, Fedora has set response to "OK")
http://www.pkgbuild.com/check_network_status.txt (Arch Linux, redirects to HTTPS)

I think it would be preferable for it to be Canonical-hosted though.

Saurav Sengupta (sauravsengupta) wrote :

Does that Lorem ipsum response for the uri in this proposal work? It didn't work for me on Ubuntu GNOME 16.10 (the login popup appeared with the root page open for nmcheck.gnome.org). I think it should be something like response=<!DOCTYPE HTML PUBLIC for uri=http://start.ubuntu.com/connectivity-check.html (see https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/997200/comments/4) because it checks from the beginning of the body content, not the rendered text; or else change the uri.

~jbicha/network-manager:master updated on 2017-02-24
fe4efd3... by Jeremy Bicha on 2017-02-24

Temporarily set URI to Debian's until a working Ubuntu one is set up

Jeremy Bicha (jbicha) wrote :

Saurav, thanks for the feedback. Yes, I see that the start.ubuntu.com URI does not work. I am going to see if I can find someone at Canonical that can set up one that works. Meanwhile, I'll set the URI to Debian's which I did test.

You also saw something else because gnome-shell hardcodes a nmcheck.gnome.org URI which I think we'll want to patch out:
https://git.gnome.org/browse/gnome-shell/tree/js/portalHelper/main.js#n28

Saurav Sengupta (sauravsengupta) wrote :

A bit off-topic here, but if you're going to patch the portal helper, could you also see if the window can be made to remain in the background (perhaps insert a set_keep_below call (https://developer.gnome.org/gtk3/stable/GtkWindow.html#gtk-window-set-keep-below) before the present_with_time call on line #165)? Sorry if this seems ignorant, but I don't have good knowledge of GTK+.

Jeremy Bicha (jbicha) wrote :

This has been merged in, similarly but slightly differently in Artful and Debian unstable.

Diff calculation failed

Calculating the branch diff failed. You can manually schedule an update if required.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/20-connectivity.conf b/debian/20-connectivity.conf
2new file mode 100644
3index 0000000..58446fb
4--- /dev/null
5+++ b/debian/20-connectivity.conf
6@@ -0,0 +1,3 @@
7+[connectivity]
8+uri=http://start.ubuntu.com/connectivity-check.html
9+response=Lorem ipsum
10diff --git a/debian/changelog b/debian/changelog
11index d211287..25f9d55 100644
12--- a/debian/changelog
13+++ b/debian/changelog
14@@ -1,3 +1,12 @@
15+network-manager (1.4.4-1ubuntu3) UNRELEASED; urgency=medium
16+
17+ * Add network-manager-connectivity-config package (LP: #997200)
18+ - Install this if you want NetworkManager to check on connection and
19+ every 5 minutes afterwards whether the network you are connected to
20+ is actually connected to the Internet.
21+
22+ -- Jeremy Bicha <jbicha@ubuntu.com> Wed, 22 Feb 2017 11:38:33 -0500
23+
24 network-manager (1.4.4-1ubuntu2) zesty; urgency=medium
25
26 * Cherry-pick back 98974a88 and 47c16e59 (network-manager switching from
27diff --git a/debian/control b/debian/control
28index f1798bb..4914cc8 100644
29--- a/debian/control
30+++ b/debian/control
31@@ -70,6 +70,7 @@ Recommends: ppp (>= 2.4.6),
32 network-manager-gnome | plasma-widget-networkmanagement | plasma-nm,
33 modemmanager | ofono,
34 Suggests: avahi-autoipd,
35+ network-manager-config-connectivity,
36 python,
37 Breaks: network-manager-gnome (<< 0.9),
38 network-manager-openvpn (<< 0.9),
39@@ -266,3 +267,18 @@ Description: GObject introspection data for NetworkManager
40 It can be used by packages using the GIRepository format to generate
41 dynamic bindings.
42
43+Package: network-manager-config-connectivity
44+Architecture: all
45+Multi-Arch: foreign
46+Depends: ${misc:Depends}
47+Description: network management framework (connectivity config)
48+ NetworkManager is a system network service that manages your network devices
49+ and connections, attempting to keep active network connectivity when
50+ available. It manages ethernet, WiFi, mobile broadband (WWAN), and PPPoE
51+ devices, and provides VPN integration with a variety of different VPN
52+ services.
53+ .
54+ This package provides the config snippet to enable NetworkManager to
55+ automatically check whether the active network connection is actually
56+ connected to the Internet. By default, this check happens every 5 minutes.
57+ This package can be uninstalled if this feature is not wanted.
58diff --git a/debian/network-manager-config-connectivity.install b/debian/network-manager-config-connectivity.install
59new file mode 100644
60index 0000000..ad61360
61--- /dev/null
62+++ b/debian/network-manager-config-connectivity.install
63@@ -0,0 +1 @@
64+debian/20-connectivity.conf /usr/lib/NetworkManager/conf.d/

Subscribers

People subscribed via source and target branches

to all changes: