Merge lp:~jbicha/livecd-rootfs/dont-enable-multiverse-for-flavors into lp:livecd-rootfs

Proposed by Jeremy Bícha
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp:~jbicha/livecd-rootfs/dont-enable-multiverse-for-flavors
Merge into: lp:livecd-rootfs
Diff against target: 39 lines (+4/-4)
1 file modified
live-build/auto/config (+4/-4)
To merge this branch: bzr merge lp:~jbicha/livecd-rootfs/dont-enable-multiverse-for-flavors
Reviewer Review Type Date Requested Status
Martin Pitt Needs Information
Adam Conrad Pending
Review via email: mp+303367@code.launchpad.net

Description of the change

Don't enable multiverse for flavors that don't need it

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Can you please explain why they don't need it? Ubiquity is more or less the same for all flavors, don't they support installing e. g. non-free wireless drivers?

review: Needs Information
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Because only some flavors have "multiverse" listed; others like Ubuntu GNOME or Kubuntu seem to work just fine without it.

I believe Mythbuntu and Ubuntu Studio need it but I'm guessing some of the other flavors used the wrong flavor as a template.

Revision history for this message
Martin Pitt (pitti) wrote :

You can also install e. g. Ubuntu itself with only free software (there's gfxboot and ubiquity options). It's not really that the desktop "needs" it, it's a question of hardware drivers. This doesn't seem particularly flavor specific to me.

Or does ubiquity add the multiverse component if it installs non-free drivers? In that case could we generalize this so that we don't need to replicate the same logic for every flavor?

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Starting at line 510, it enables multiverse for specific hardware platforms.

Enabling multiverse doesn't seem particularly useful for wireless drivers since you'd still need internet or (pre-downloaded packages which aren't on the current iso's) to be able to install them, but if you have Internet, why do you need wireless drivers...?

I don't see why Lubuntu, Xubuntu and MATE need multiverse but Kubuntu, Kylin and GNOME don't. I believe Mythbuntu and Studio install multiverse packages so it makes sense for them to be able to install updated versions of those packages.

Revision history for this message
Martin Pitt (pitti) wrote :

> Enabling multiverse doesn't seem particularly useful for wireless drivers

It is, they are shipped on the ISO's archive pool: http://cdimage.ubuntu.com/cdimage/daily-live/current/yakkety-desktop-amd64.list

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I believe those are only main and restricted packages.

Revision history for this message
Martin Pitt (pitti) wrote :

Oh right, sorry, got confused. But the question still stands -- I don't believe that there is a fundamental flavor-related conceptual difference wrt. enabling multiverse by default -- most of our images don't need multiverse for anything (maybe all of them, I didn't check all flavors), but it is still enabled so that the user can install packages from it.

Disabling multiverse by default would be a legitimate change IMHO (users can enable it in software-properties), but it would be better to do it consistently everywhere then -- and flip the condition around so that special cases like mythbuntu explicitly have to enable multiverse (with a comment that justifies that).

Revision history for this message
Steve Langasek (vorlon) wrote :

This MP seems to have gone stale, Martin raised objections to this being a flavor-specific change which have gone unanswered.

Please note that the Foundations team is planning a transition of livecd-rootfs from bzr to git in early December, at which point this MP will necessarily be invalidated. So it would be good to resolve this before then (either accepting or rejecting).

Revision history for this message
Balint Reczey (rbalint) wrote :

The target Bazaar branch is not active anymore.
Please resubmit the merge proposal against https://code.launchpad.net/~ubuntu-core-dev/livecd-rootfs/+git/livecd-rootfs/+ref/ubuntu/master .

Unmerged revisions

1433. By Jeremy Bícha

live-build/auto/config: Don't enable multiverse for flavors that don't need it

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'live-build/auto/config'
2--- live-build/auto/config 2016-08-15 22:17:52 +0000
3+++ live-build/auto/config 2016-08-19 06:03:32 +0000
4@@ -264,7 +264,7 @@
5 case $ARCH in
6 amd64) add_package live linux-signed-generic ;;
7 esac
8- COMPONENTS='main restricted universe multiverse'
9+ COMPONENTS='main restricted universe'
10 case $ARCH in
11 amd64|i386) KERNEL_FLAVOURS=generic ;;
12 esac
13@@ -290,7 +290,7 @@
14 case $ARCH in
15 amd64) add_package live linux-signed-generic ;;
16 esac
17- COMPONENTS='main restricted universe multiverse'
18+ COMPONENTS='main restricted universe'
19 case $ARCH in
20 amd64|i386) KERNEL_FLAVOURS=generic ;;
21 esac
22@@ -306,7 +306,7 @@
23 case $ARCH in
24 amd64) add_package live linux-signed-generic ;;
25 esac
26- COMPONENTS='main restricted universe multiverse'
27+ COMPONENTS='main restricted universe'
28 case $ARCH in
29 amd64|i386) KERNEL_FLAVOURS=generic ;;
30 esac
31@@ -327,7 +327,7 @@
32 case $ARCH in
33 amd64) add_package live linux-signed-generic ;;
34 esac
35- COMPONENTS='main restricted universe multiverse'
36+ COMPONENTS='main restricted universe'
37 ;;
38
39 ubuntustudio-dvd)

Subscribers

People subscribed via source and target branches