Merge lp:~jbicha/light-themes/fix-ambiance-in-gnome-panel into lp:~ubuntu-art-pkg/light-themes/trunk

Proposed by Jeremy Bicha on 2012-04-22
Status: Merged
Merged at revision: 225
Proposed branch: lp:~jbicha/light-themes/fix-ambiance-in-gnome-panel
Merge into: lp:~ubuntu-art-pkg/light-themes/trunk
Diff against target: 111 lines (+20/-2)
2 files modified
Ambiance/gtk-3.0/apps/gnome-panel.css (+11/-2)
Radiance/gtk-3.0/apps/gnome-panel.css (+9/-0)
To merge this branch: bzr merge lp:~jbicha/light-themes/fix-ambiance-in-gnome-panel
Reviewer Review Type Date Requested Status
Matthias Niess (community) Approve on 2012-07-02
Bob Bib (community) Approve on 2012-05-21
Ubuntu Artwork Packagers 2012-04-22 Pending
Review via email: mp+103001@code.launchpad.net

Description of the change

This was actually done by ~zonsaja. I just formatted it into a patch.

To post a comment you must log in.
225. By Jeremy Bicha on 2012-04-22

- Add backdrop option, fixes Ambiance theming for menu bar & window list
  (LP: #955376, LP: #981289)
- Enable the Ubuntu icon for the Applications menu (LP: #986988)

226. By Jeremy Bicha on 2012-04-23

Apply changes to Radiance too

Bob Bib (bobbib) wrote :

Looks fine.
When will it be merged?

review: Approve
Matthias Niess (mniess) wrote :

I have tried it and it works nicely. Why won't it be approved. Who needs to see this?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Ambiance/gtk-3.0/apps/gnome-panel.css'
--- Ambiance/gtk-3.0/apps/gnome-panel.css 2012-03-06 15:23:14 +0000
+++ Ambiance/gtk-3.0/apps/gnome-panel.css 2012-04-23 13:29:18 +0000
@@ -1,4 +1,7 @@
1/* Fallback Mode Panel */1/* Fallback Mode Panel */
2PanelWidget :backdrop,
3PanelApplet :backdrop,
4PanelToplevel :backdrop,
2PanelWidget,5PanelWidget,
3PanelApplet,6PanelApplet,
4PanelToplevel {7PanelToplevel {
@@ -14,6 +17,7 @@
14 border-width: 0;17 border-width: 0;
15}18}
1619
20PanelSeparator:backdrop,
17PanelSeparator {21PanelSeparator {
18 border-width: 0;22 border-width: 0;
19 background-image: -gtk-gradient (linear, left top, left bottom,23 background-image: -gtk-gradient (linear, left top, left bottom,
@@ -28,6 +32,7 @@
28PanelApplet > GtkMenuBar.menubar.menuitem,32PanelApplet > GtkMenuBar.menubar.menuitem,
29PanelMenuBar.menubar,33PanelMenuBar.menubar,
30PanelMenuBar.menubar.menuitem {34PanelMenuBar.menubar.menuitem {
35 -PanelMenuBar-icon-visible: true;
31 background-image: -gtk-gradient (linear, left top, left bottom,36 background-image: -gtk-gradient (linear, left top, left bottom,
32 from (shade (@dark_bg_color, 1.5)),37 from (shade (@dark_bg_color, 1.5)),
33 to (shade (@dark_bg_color, 1.05)));38 to (shade (@dark_bg_color, 1.05)));
@@ -41,6 +46,7 @@
41 border-width: 0;46 border-width: 0;
42}47}
4348
49PanelApplet .button:backdrop,
44PanelApplet .button {50PanelApplet .button {
45 -GtkButton-inner-border: 2;51 -GtkButton-inner-border: 2;
4652
@@ -57,10 +63,12 @@
5763
58 -unico-border-gradient: none;64 -unico-border-gradient: none;
59 -unico-glow-radius: 0;65 -unico-glow-radius: 0;
60 -unico-inner-stroke-width: 0;66 -unico-inner-stroke-width: 0px;
61 -unico-outer-stroke-width: 0;67 -unico-outer-stroke-width: 0px;
62}68}
6369
70PanelApplet .button:prelight:active:backdrop,
71PanelApplet .button:active:backdrop,
64PanelApplet .button:prelight:active,72PanelApplet .button:prelight:active,
65PanelApplet .button:active {73PanelApplet .button:active {
66 background-image: -gtk-gradient (linear, left top, left bottom,74 background-image: -gtk-gradient (linear, left top, left bottom,
@@ -76,6 +84,7 @@
76 -unico-outer-stroke-width: 0;84 -unico-outer-stroke-width: 0;
77}85}
7886
87PanelApplet .button:prelight:backdrop,
79PanelApplet .button:prelight {88PanelApplet .button:prelight {
80 background-image: -gtk-gradient (linear, left top, left bottom,89 background-image: -gtk-gradient (linear, left top, left bottom,
81 from (shade (@dark_bg_color, 1.7)),90 from (shade (@dark_bg_color, 1.7)),
8291
=== modified file 'Radiance/gtk-3.0/apps/gnome-panel.css'
--- Radiance/gtk-3.0/apps/gnome-panel.css 2012-03-06 15:23:14 +0000
+++ Radiance/gtk-3.0/apps/gnome-panel.css 2012-04-23 13:29:18 +0000
@@ -1,4 +1,7 @@
1/* Fallback Mode Panel */1/* Fallback Mode Panel */
2PanelWidget :backdrop,
3PanelApplet :backdrop,
4PanelToplevel :backdrop,
2PanelWidget,5PanelWidget,
3PanelApplet,6PanelApplet,
4PanelToplevel {7PanelToplevel {
@@ -14,6 +17,7 @@
14 border-width: 0;17 border-width: 0;
15}18}
1619
20PanelSeparator:backdrop,
17PanelSeparator {21PanelSeparator {
18 border-width: 0;22 border-width: 0;
19 background-image: -gtk-gradient (linear, left top, left bottom,23 background-image: -gtk-gradient (linear, left top, left bottom,
@@ -28,6 +32,7 @@
28PanelApplet > GtkMenuBar.menubar.menuitem,32PanelApplet > GtkMenuBar.menubar.menuitem,
29PanelMenuBar.menubar,33PanelMenuBar.menubar,
30PanelMenuBar.menubar.menuitem {34PanelMenuBar.menubar.menuitem {
35 -PanelMenuBar-icon-visible: true;
31 background-image: -gtk-gradient (linear, left top, left bottom,36 background-image: -gtk-gradient (linear, left top, left bottom,
32 from (shade (@dark_bg_color, 1.15)),37 from (shade (@dark_bg_color, 1.15)),
33 to (shade (@dark_bg_color, 0.95)));38 to (shade (@dark_bg_color, 0.95)));
@@ -41,6 +46,7 @@
41 border-width: 0;46 border-width: 0;
42}47}
4348
49PanelApplet .button:backdrop,
44PanelApplet .button {50PanelApplet .button {
45 -GtkButton-inner-border: 2;51 -GtkButton-inner-border: 2;
4652
@@ -59,6 +65,8 @@
59 -unico-outer-stroke-width: 0px;65 -unico-outer-stroke-width: 0px;
60}66}
6167
68PanelApplet .button:prelight:active:backdrop,
69PanelApplet .button:active:backdrop,
62PanelApplet .button:prelight:active,70PanelApplet .button:prelight:active,
63PanelApplet .button:active {71PanelApplet .button:active {
64 background-image: -gtk-gradient (linear, left top, left bottom,72 background-image: -gtk-gradient (linear, left top, left bottom,
@@ -74,6 +82,7 @@
74 -unico-outer-stroke-width: 0;82 -unico-outer-stroke-width: 0;
75}83}
7684
85PanelApplet .button:prelight:backdrop,
77PanelApplet .button:prelight {86PanelApplet .button:prelight {
78 background-image: -gtk-gradient (linear, left top, left bottom,87 background-image: -gtk-gradient (linear, left top, left bottom,
79 from (shade (@dark_bg_color, 1.2)),88 from (shade (@dark_bg_color, 1.2)),

Subscribers

People subscribed via source and target branches