Merge lp:~jbicha/indicator-session/capitalize-Desktop-Mode into lp:indicator-session

Proposed by Jeremy Bicha on 2017-03-09
Status: Merged
Approved by: Lukáš Tinkl on 2017-03-09
Approved revision: 485
Merged at revision: 485
Proposed branch: lp:~jbicha/indicator-session/capitalize-Desktop-Mode
Merge into: lp:indicator-session
Diff against target: 25 lines (+2/-2)
2 files modified
po/indicator-session.pot (+1/-1)
src/service.c (+1/-1)
To merge this branch: bzr merge lp:~jbicha/indicator-session/capitalize-Desktop-Mode
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) Approve on 2017-03-09
Matthew Paul Thomas design 2017-03-09 Approve on 2017-03-09
Review via email: mp+319461@code.launchpad.net

Commit Message

Rename "Desktop mode" switch to "Desktop Mode" to match capitalization style

Description of the Change

Everything else in the default indicator menus uses Title Case so fix this to match.

To post a comment you must log in.
Matthew Paul Thomas (mpt) wrote :

+1

review: Approve (design)
Lukáš Tinkl (lukas-kde) wrote :

Top ack based on design feedback

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/indicator-session.pot'
2--- po/indicator-session.pot 2017-02-07 21:04:44 +0000
3+++ po/indicator-session.pot 2017-03-09 15:52:09 +0000
4@@ -45,7 +45,7 @@
5 msgstr ""
6
7 #: ../src/service.c:471
8-msgid "Desktop mode"
9+msgid "Desktop Mode"
10 msgstr ""
11
12 #: ../src/service.c:487
13
14=== modified file 'src/service.c'
15--- src/service.c 2016-11-10 22:36:35 +0000
16+++ src/service.c 2017-03-09 15:52:09 +0000
17@@ -468,7 +468,7 @@
18 if (p->usage_mode_action && g_getenv ("MIR_SOCKET") != NULL) // only under unity8
19 {
20 GMenuItem * menu_item = NULL;
21- menu_item = g_menu_item_new(_("Desktop mode"), "indicator.usage-mode");
22+ menu_item = g_menu_item_new(_("Desktop Mode"), "indicator.usage-mode");
23 g_menu_item_set_attribute(menu_item, "x-canonical-type", "s", "com.canonical.indicator.switch");
24 g_menu_append_item(menu, menu_item);
25 g_object_unref(menu_item);

Subscribers

People subscribed via source and target branches