Indicator Date and Time

Merge lp:~jbicha/indicator-datetime/capitalize-settings into lp:indicator-datetime

  1. capitalize-settings
  2. Merge into trunk.16.10
Proposed by Jeremy Bícha
Status: Merged
Approved by: Lukáš Tinkl
Approved revision: 481
Merged at revision: 481
Proposed branch: lp:~jbicha/indicator-datetime/capitalize-settings
Merge into: lp:indicator-datetime
Diff against target: 25 lines (+2/-2)
2 files modified
po/indicator-datetime.pot (+1/-1)
src/menu.cpp (+1/-1)
To merge this branch: bzr merge lp:~jbicha/indicator-datetime/capitalize-settings
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) Approve
Matthew Paul Thomas (community) design Approve
Review via email: mp+319462@code.launchpad.net

Commit message

Capitalize Settings in indicator menu to match capitalization style

Description of the change

Since all the other default indicators use Title Case…

To post a comment you must log in.
Revision history for this message
Jeremy Bícha (jbicha) wrote :

https://bileto.ubuntu.com/#/ticket/2557

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

+1

review: Approve (design)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

Top ack based on design feedback

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/indicator-datetime.pot'
2--- po/indicator-datetime.pot 2017-02-09 17:28:21 +0000
3+++ po/indicator-datetime.pot 2017-03-09 16:09:58 +0000
4@@ -36,7 +36,7 @@
5 msgstr ""
6
7 #: ../src/menu.cpp:491
8-msgid "Time & Date settings…"
9+msgid "Time & Date Settings…"
10 msgstr ""
11
12 #: ../src/menu.cpp:546
13
14=== modified file 'src/menu.cpp'
15--- src/menu.cpp 2016-06-16 16:55:27 +0000
16+++ src/menu.cpp 2017-03-09 16:09:58 +0000
17@@ -488,7 +488,7 @@
18 action_name = nullptr;
19
20 if (action_name != nullptr)
21- g_menu_append (menu, _("Time & Date settings…"), action_name);
22+ g_menu_append (menu, _("Time & Date Settings…"), action_name);
23
24 return G_MENU_MODEL (menu);
25 }

Subscribers

People subscribed via source and target branches