Merge lp:~jbicha/hud/build-depend-on-valac-not-gir into lp:hud/13.10

Proposed by Jeremy Bicha on 2013-06-07
Status: Merged
Approved by: Ted Gould on 2013-07-12
Approved revision: 272
Merged at revision: 300
Proposed branch: lp:~jbicha/hud/build-depend-on-valac-not-gir
Merge into: lp:hud/13.10
Diff against target: 20 lines (+1/-2)
1 file modified
debian/control (+1/-2)
To merge this branch: bzr merge lp:~jbicha/hud/build-depend-on-valac-not-gir
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2013-07-12
Ted Gould (community) 2013-06-07 Approve on 2013-06-07
Review via email: mp+168031@code.launchpad.net

Commit message

* Drop explicit build-depends on gir1.2-dee-1.0
* Build against default valac

Description of the change

This is dependent on https://code.launchpad.net/~jbicha/dee/have-dev-depend-on-gir/+merge/168030

This change will have hud build against the default valac (for Ubuntu 13.10 this is currently valac 0.18 but we may switch to 0.20 as Debian testing already has). I have successfully test-built against valac-0.20.

To post a comment you must log in.
Ted Gould (ted) wrote :

Approved, waiting on the dee landing though.

review: Approve
Jeremy Bicha (jbicha) wrote :

Ted, could you approve this now? Thanks

Ted Gould (ted) wrote :

Yup, looks good!

PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Jeremy Bicha (jbicha) wrote :

Ted, can you try approving this again? Thanks!

PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2013-06-03 16:39:37 +0000
+++ debian/control 2013-06-07 12:01:58 +0000
@@ -7,7 +7,6 @@
7 dbus-test-runner,7 dbus-test-runner,
8 debhelper (>= 9),8 debhelper (>= 9),
9 dh-autoreconf,9 dh-autoreconf,
10 gir1.2-dee-1.0,
11 gnome-common,10 gnome-common,
12 gnome-doc-utils,11 gnome-doc-utils,
13 gobject-introspection,12 gobject-introspection,
@@ -25,7 +24,7 @@
25 libgtk-3-dev,24 libgtk-3-dev,
26 libsqlite3-dev,25 libsqlite3-dev,
27 sqlite3,26 sqlite3,
28 valac-0.18,27 valac,
29 xvfb,28 xvfb,
30 python3-dbusmock,29 python3-dbusmock,
31 libpocketsphinx-dev (>= 0.8),30 libpocketsphinx-dev (>= 0.8),

Subscribers

People subscribed via source and target branches