Merge lp:~jbicha/friends/build-depend-on-dev-not-gir into lp:friends

[Jeremy Bícha]

This is dependent on

https://code.launchpad.net/~jbicha/dee/have-dev-depend-on-gir/+merge/168030
https://code.launchpad.net/~jbicha/indicator-messages/have-dev-depend-on-gir/+merge/168040
https://code.launchpad.net/~jbicha/libdbusmenu/have-dev-depend-on-gir/+merge/168038
https://code.launchpad.net/~jbicha/libunity/have-dev-depend-on-gir/+merge/168043

[Ken VanDine (ken-vandine)]

Is this really desirable? Since it really only depends on having the gir installed for the tests, it doesn't actually depend on any files provided by those dev packages. Seems like it just adds more overhead in the build to install more stuff than is really required. Or is this part of a bigger effort for consistency?

review: Needs Information

[Jeremy Bícha (jbicha)]

Mmm, I guess it's mostly a style thing since it doesn't actually change anything in the build.

[Jeremy Bícha (jbicha)]

Also it could make backports more difficult since those 4 libraries I mentioned in the initial comment are missing their -gir dependency in Raring.

[Ken VanDine (ken-vandine)]

With the amount of times this gets rebuilt automatically, I'd say lets not approve this, it would just add a lot of extra churn installing the extra packages and their depends during build. I did go through those other MP's and added approvals for them. Thanks!

review: Disapprove

Unmerged revisions

205. By Jeremy Bícha on 2013-06-07

build-depend on -dev packages instead of gir- packages

=== modified file 'debian/control'
--- debian/control	2013-06-06 18:06:19 +0000
+++ debian/control	2013-06-07 12:37:33 +0000
@@ -4,22 +4,19 @@
 Maintainer: Ubuntu Desktop Team <[e-mail]>
 Build-Depends: dbus-test-runner,
                debhelper (>= 9),
+               dh-autoreconf,
                evolution-data-server,
-               gir1.2-dbusmenu-glib-0.4,
-               gir1.2-dee-1.0,
-               gir1.2-ebook-1.2 (>= 3.8),
-               gir1.2-ebookcontacts-1.2 (>= 3.8),
-               gir1.2-edataserver-1.2 (>= 3.8),
-               gir1.2-gdkpixbuf-2.0,
-               gir1.2-glib-2.0,
-               gir1.2-messagingmenu-1.0,
-               gir1.2-networkmanager-1.0,
-               gir1.2-notify-0.7,
-               gir1.2-signon-1.0,
-               gir1.2-soup-2.4,
-               gir1.2-unity-5.0,
                libaccounts-glib-dev (>= 1.10),
-               libsignon-glib1,
+               libdee-dev,
+               libdbusmenu-glib-dev,
+               libebook1.2-dev (>= 3.8),
+               libedataserver1.2-dev (>= 3.8),
+               libmessaging-menu-dev,
+               libnm-glib-dev,
+               libnotify-dev,
+               libsignon-glib-dev,
+               libsoup2.4-dev,
+               libunity-dev,
                python3,
                python3-dbus,
                python3-distutils-extra,
@@ -29,9 +26,7 @@
                python3-pkg-resources,
                python3-setuptools,
                shared-mime-info,
-               valac,
-               libdee-dev,
-               dh-autoreconf,
+               valac
 Standards-Version: 3.9.3
 Homepage: https://launchpad.net/friends
 # If you aren't a member of ~super-friends but need to upload packaging changes,