Merge lp:~jbicha/firefox/dont-depend-on-gtk2 into lp:~mozillateam/firefox/firefox-beta.artful

Proposed by Jeremy Bícha
Status: Needs review
Proposed branch: lp:~jbicha/firefox/dont-depend-on-gtk2
Merge into: lp:~mozillateam/firefox/firefox-beta.artful
Diff against target: 14 lines (+4/-0)
1 file modified
debian/build/ (+4/-0)
To merge this branch: bzr merge lp:~jbicha/firefox/dont-depend-on-gtk2
Reviewer Review Type Date Requested Status
Rico Tzschichholz Pending
Review via email:

Description of the change

Firefox has only one file that naturally depends on gtk2:

I think that file is only used by the Flash plugin.


All the Flash plugin packages in Ubuntu and Debian already depend on libgtk2.0-0
- adobe-flashplugin
- flashplugin-installer (from source flashplugin-nonfree )
- pepperflashplugin-nonfree (works in Chromium not Firefox but mentioned for completeness)

Therefore, I propose we use the same hack we've used in several other packages to drop the depends on gtk2. The final packages in the default 18.04 install to pull in gtk2 are Firefox, Thunderbird, and debconf (for libgtk2-perl). The tracker bug for that issue is LP: #1585903

The only risk I see is that it is possible for someone to manually try to install Flash without using the Ubuntu packages but I don't understand why anyone would do that and I don't think we should worry about that use case.

I haven't tested Thunderbird yet. I believe the change is unsafe on Thunderbird 52, but I think it would be fine for Thunderbird 57 or 58 Beta. Based on the release schedule, I think we could ship 59 (Beta?) with Ubuntu 18.04 LTS.

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Sorry for proposing against the wrong branch.

Do you think these changes will be cherry-picked in for Firefox 58 too?

Unmerged revisions

1218. By Jeremy Bícha

Don't depend on gtk2. gtk2 is only needed by Flash but all the Flash
packages already depend on gtk2.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/build/'
2--- debian/build/ 2017-11-28 06:36:40 +0000
3+++ debian/build/ 2017-12-05 05:45:00 +0000
4@@ -44,6 +44,10 @@
6 # Prevent some files from being cleaned to avoid build failures
7 DEB_CLEAN_EXCLUDE := Cargo.toml.orig
8+# Flash should be the only thing that requires gtk2, but all the Debian &
9+# Ubuntu Flash packages already depend on gtk2. So skip depending on it
10+# so that we can install a gtk2-free system
11+DEB_DH_SHLIBDEPS_ARGS_ALL += -- -xlibgtk2.0-0
12 # Don't save debug symbols in firefox-dbg (rely on pkg-create-dbgsym to create
13 # ddeb packages for us). This is needed as long as there is a firefox-dbg
14 # transitional package


People subscribed via source and target branches

to all changes: