Merge lp:~jbicha/deja-dup/fix-help-link into lp:deja-dup/28

Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 1457
Proposed branch: lp:~jbicha/deja-dup/fix-help-link
Merge into: lp:deja-dup/28
Diff against target: 22 lines (+9/-0)
1 file modified
preferences/PreferencesPanel.c (+9/-0)
To merge this branch: bzr merge lp:~jbicha/deja-dup/fix-help-link
Reviewer Review Type Date Requested Status
Déjà Dup Developers Pending
Review via email: mp+174287@code.launchpad.net

Commit message

fix control-center help link

Description of the change

This fixes System Settings' built-in help link in the System Settings menu in the top menu bar. Also, F1 will now work correctly.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

This looks good, works as advertised. I wonder if we shouldn't also remove the Help button and add a similar global app menu with Help/Close to deja-dup-preferences?

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Yeah, that should be possible since it's already using GtkApplication.

Revision history for this message
Jim Campbell (jwcampbell) wrote :

Tangentially related, but Michael had you seen my proposed merge for the
documentation?

https://code.launchpad.net/~jwcampbell/deja-dup/deja-dup-doc-updates

Jim

On Mon, Jul 15, 2013 at 3:50 PM, Jeremy Bicha <email address hidden> wrote:

> Yeah, that should be possible since it's already using GtkApplication.
> --
> https://code.launchpad.net/~jbicha/deja-dup/fix-help-link/+merge/174287
> You are subscribed to branch lp:deja-dup.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'preferences/PreferencesPanel.c'
2--- preferences/PreferencesPanel.c 2012-06-05 18:49:47 +0000
3+++ preferences/PreferencesPanel.c 2013-07-11 20:19:32 +0000
4@@ -50,9 +50,18 @@
5 {
6 }
7
8+static const char *
9+deja_dup_preferences_panel_get_help_uri (CcPanel *panel)
10+{
11+ return "help:deja-dup";
12+}
13+
14 static void
15 deja_dup_preferences_panel_class_init (DejaDupPreferencesPanelClass *klass)
16 {
17+ CcPanelClass *panel_class = CC_PANEL_CLASS (klass);
18+
19+ panel_class->get_help_uri = deja_dup_preferences_panel_get_help_uri;
20 }
21
22 static void

Subscribers

People subscribed via source and target branches