Merge ~jbicha/deja-dup:build-with-vala36 into deja-dup:master
Proposed by
Jeremy Bicha
on 2017-06-16
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 0b445d58ec72f3e3991cef139e2b2a4e802ae42f | ||||
| Proposed branch: | ~jbicha/deja-dup:build-with-vala36 | ||||
| Merge into: | deja-dup:master | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry | 2017-06-16 | Approve on 2017-06-19 | |
|
Review via email:
|
|||
Description of the Change
By the way, I can't actually get your master branch to compile so I reverted the Preferences reorganization 295926ac7ffa and worked from there.
vala 0.36 (generally distributed along GNOME 3.24) has stricter syntax requirements and deja-dup fails to build with the new version.
The first commit fixes the build failure, but requires vala 0.36. If you don't want to require vala 0.36, we can do something like https:/
The second commit just fixes some warnings. I see a few other warnings but this was one of the more annoying ones to see in the build log.
To post a comment you must log in.
| Jeremy Bicha (jbicha) wrote : | # |
| Jeremy Bicha (jbicha) wrote : | # |
The gnome-chess commit had a typo. It should be #endif not #fi.
| Michael Terry (mterry) wrote : | # |
Looks good to me. I also updated trunk's debian/control to require valac 0.36.
review:
Approve
vala 0.36 was just uploaded to Ubuntu 17.10 "artful" this week.