Merge lp:~jbicha/activity-log-manager/turn-off-recently-used-too into lp:activity-log-manager

Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 67
Proposed branch: lp:~jbicha/activity-log-manager/turn-off-recently-used-too
Merge into: lp:activity-log-manager
Diff against target: 23 lines (+5/-0)
1 file modified
src/unified-privacy.vala (+5/-0)
To merge this branch: bzr merge lp:~jbicha/activity-log-manager/turn-off-recently-used-too
Reviewer Review Type Date Requested Status
Manish Sinha (मनीष सिन्हा) Approve
Review via email: mp+173383@code.launchpad.net

Description of the change

When a user turns off Recording File & Application Usage, both Zeitgeist and the GTK/GNOME recently used feature will stop adding new items to their databases.

As for the second half of the bug, it looks to me like GNOME's Privacy panel doesn't yet include an option to clear the recently used database. We could just remove the recently-used.xbel file if a user chooses to "Clear Usage Data from all time".

To post a comment you must log in.
Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unified-privacy.vala'
2--- src/unified-privacy.vala 2013-07-03 08:09:42 +0000
3+++ src/unified-privacy.vala 2013-07-07 21:25:30 +0000
4@@ -66,8 +66,12 @@
5
6 private Gtk.Menu exception_menu;
7
8+ private GLib.Settings privacy_settings;
9+
10 public PrivacyWidget (Blacklist blacklist_interface) {
11 GLib.Object (orientation: Orientation.VERTICAL, spacing:10);
12+
13+ privacy_settings = new GLib.Settings ("org.gnome.desktop.privacy");
14
15 this.blacklist = blacklist_interface;
16 //File/Folder stuffs
17@@ -188,6 +192,7 @@
18 var recording = !blacklist.get_incognito();
19 if (this.record_button.active != recording) {
20 blacklist.set_incognito(recording);
21+ privacy_settings.set_boolean("remember-recent-files", record_button.active);
22 }
23 });
24

Subscribers

People subscribed via source and target branches