Merge lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations into lp:activity-log-manager

Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 81
Proposed branch: lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations
Merge into: lp:activity-log-manager
Diff against target: 18 lines (+2/-3)
1 file modified
src/unified-privacy.vala (+2/-3)
To merge this branch: bzr merge lp:~jbicha/activity-log-manager/add-apps-drop-spreadsheets-presentations
Reviewer Review Type Date Requested Status
Manish Sinha (मनीष सिन्हा) Approve
Review via email: mp+174096@code.launchpad.net

Description of the change

...and changes the capitalization of "Chat Logs" to "Chat logs" which I think fits better in the style Unity is aiming towards in the dash and elsewhere.

To post a comment you must log in.
Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

I am not sure if dropping Presentations and Spreadsheets makes sense because Datahub's recent-manager-provider.vala does take care of openoffice stuff. Check lines 113 and it is able to deduce the proper Interpretation from the mimetype (line 148)

review: Needs Information
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Yes, Zeitgeist can handle Spreadsheets separately than Presentations but I can't think of a good reason why a typical user wouldn't just want a single toggle for all document types.

I used zg's data/ontology/nfo.trig to see that Spreadsheets and Presentations are subclasses of Documents anyway (as are several other document types that we don't have toggles for).

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/unified-privacy.vala'
2--- src/unified-privacy.vala 2013-07-09 23:46:11 +0000
3+++ src/unified-privacy.vala 2013-07-11 02:28:33 +0000
4@@ -115,13 +115,12 @@
5 });
6
7 mime_dict = new HashMap<string, string>(str_hash, str_equal);
8+ mime_dict.set(_("Applications"), NFO.SOFTWARE);
9 mime_dict.set(_("Music"), NFO.AUDIO);
10 mime_dict.set(_("Videos"), NFO.VIDEO);
11 mime_dict.set(_("Pictures"), NFO.IMAGE);
12 mime_dict.set(_("Documents"), NFO.DOCUMENT);
13- mime_dict.set(_("Presentations"), NFO.PRESENTATION);
14- mime_dict.set(_("Spreadsheets"), NFO.SPREADSHEET);
15- mime_dict.set(_("Chat Logs"), NMO.IMMESSAGE);
16+ mime_dict.set(_("Chat logs"), NMO.IMMESSAGE);
17 mime_dict.set(_("Emails"), NMO.EMAIL);
18 mime_dict.set(_("Websites"), NFO.WEBSITE);
19

Subscribers

People subscribed via source and target branches