Merge lp:~jbicha/account-plugins/depend-on-signon-plugin-password into lp:account-plugins

Proposed by Jeremy Bicha on 2016-08-29
Status: Merged
Approved by: Alberto Mardegan on 2016-08-30
Approved revision: 169
Merged at revision: 169
Proposed branch: lp:~jbicha/account-plugins/depend-on-signon-plugin-password
Merge into: lp:account-plugins
Diff against target: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
To merge this branch: bzr merge lp:~jbicha/account-plugins/depend-on-signon-plugin-password
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) 2016-08-29 Approve on 2016-08-30
dobey (community) 2016-08-29 Approve on 2016-08-29
Review via email: mp+304283@code.launchpad.net

Commit message

* Have account-plugin-owncloud depend on signon-plugin-password

Description of the change

evolution-data-server-online-accounts no longer depends on signon-plugin-password
https://launchpad.net/ubuntu/+source/evolution-data-server/3.21.90-0ubuntu3

I'm told that account plugins using oauth don't need signon-plugin-password

data/providers/owncloud.provider.in.in
I am surprised that from my analysis OwnCloud is the only account plugin in yakkety that doesn't use oauth (or at least depend on mcp-account-manager-uoa which already depends on signon-plugin-password).

To post a comment you must log in.
169. By Jeremy Bicha on 2016-08-29

Have account-plugin-owncloud depend on signon-plugin-password

dobey (dobey) :
review: Approve
Alberto Mardegan (mardy) wrote :

Thanks Jeremy, this is totally correct.

review: Approve
Alberto Mardegan (mardy) wrote :

Actually, given that the original issue is with EDS, which needs it for the Yahoo plugin (Google and Windows Mail both support authenticating to IMAP via OAuth), it would be a good idea to add a "Recommends" in the account-plugin-yahoo too. Or we risk breaking EDS, if one day we decide to remove the owncloud plugin.

You are very welcome to push that change to this same branch :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2016-07-14 20:27:37 +0000
3+++ debian/control 2016-08-29 19:00:39 +0000
4@@ -151,6 +151,7 @@
5 Package: account-plugin-owncloud
6 Architecture: all
7 Depends: ${misc:Depends},
8+ signon-plugin-password,
9 ubuntu-system-settings-online-accounts,
10 Description: Online account plugin for Unity - ownCloud
11 This plugin adds support for creating ownCloud accounts in the Unity Control

Subscribers

People subscribed via source and target branches

to all changes: