~jbfzs/dkimpy:integration

Last commit made on 2018-12-17
Get this branch:
git clone -b integration https://git.launchpad.net/~jbfzs/dkimpy
Only Jonathan Bastien-Filiatrault can upload to this branch. If you are Jonathan Bastien-Filiatrault please log in for upload directions.

Branch merges

Branch information

Name:
integration
Repository:
lp:~jbfzs/dkimpy

Recent commits

0361edb... by Jonathan Bastien-Filiatrault <email address hidden>

Merge branch 'content_debugging' into integration

82bef59... by Jonathan Bastien-Filiatrault <email address hidden>

Don't log message content by default.

Right now, it is quite easy to end up logging the whole message in the
log when verifying signatures. This can result in wasted resources
writing the log to disk and increasing memory usage. This can also be
a private data leak if logging is put in DEBUG in a production
environment.

10af791... by Jonathan Bastien-Filiatrault <email address hidden>

Handle signature.endswith(b"\r\n \r\n") case.

On the current master, there is an edge case with a 1024 bit key where
a signature header ends with a line of only FWS (b"vqwjkb=\r\n \r\n").

How to reproduce on current master:

dkim.sign(message=MAIL, selector=b'sel', domain=b'example.com', privkey=KEY)

Where KEY is generated using certtool -p --bits=1024 and MAIL is a valid email.

8723a2e... by Jonathan Bastien-Filiatrault <email address hidden>

Clearer condition.

6f64152... by Jonathan Bastien-Filiatrault <email address hidden>

Don't insert an extra space at the end of the line when doing a soft fold.

Trailing whitespaces are best avoided.

df52e7c... by Jonathan Bastien-Filiatrault <email address hidden>

Do not take the name length into account on the second line when folding.

Setting namelen could have no effect, my guess is that this was the
original intention of the code.

This results in more efficient usage of lines.

882d14c... by Jonathan Bastien-Filiatrault <email address hidden>

Avoid making a fresh slice of the whole email on each iteration.

An update to yesterday's patch. Should avoid copying the mail byte
string more than once.

Tested on Python 2.7 and 3.6.

903cc90... by Scott Kitterman

Changelog and version for starting 0.9.2

7dee16a... by Jonathan Bastien-Filiatrault

Refactor canonicalization.py strip_trailing_lines to avoid using re for more consistent processing across python versions

84efc4a... by Scott Kitterman

Release 0.9.1