Merge lp:~jba-aps/epics-base/dbdcat into lp:~epics-core/epics-base/3.15
Proposed by
Janet B. Anderson
Status: | Merged |
---|---|
Merged at revision: | 12533 |
Proposed branch: | lp:~jba-aps/epics-base/dbdcat |
Merge into: | lp:~epics-core/epics-base/3.15 |
Diff against target: |
154 lines (+65/-2) (has conflicts) 6 files modified
configure/RULES.Db (+29/-2) configure/os/CONFIG.UnixCommon.Common (+1/-0) configure/os/CONFIG.win32-x86-mingw.Common (+1/-0) configure/os/CONFIG.win32-x86.Common (+1/-0) documentation/RELEASE_NOTES.html (+31/-0) src/tools/dbdExpand.pl (+2/-0) Text conflict in documentation/RELEASE_NOTES.html |
To merge this branch: | bzr merge lp:~jba-aps/epics-base/dbdcat |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Johnson | Approve | ||
Review via email: mp+234009@code.launchpad.net |
Description of the change
Added concatenation of database definition files with no database expansion.
To post a comment you must log in.
RULES.Db has a commented-out line in the rule for $(COMMON_ DBDCATS) :$(COMMON_ DIR)/%. dbd which looks like you probably didn't mean to leave it there.
Should dbdExpand print an error message when it gets run with no input files to expand? I think we should try to make it as easy as we can for users to understand what they did wrong when this happens, even though the build will fail immediately afterwards anyway with this code. I would like dbdExpand to exit with an error status in this case as well (causing GNUmake to stop immediately), so instead of exit 0 I suggest using die with a suitable message string (that ends in a newline to suppress the line-number that Perl will append to it otherwise). The message should include the name of the DBD file it was being asked to create.