Merge lp:~jayrod/qbzr/bug1030343 into lp:qbzr

Proposed by Jared Silva
Status: Merged
Approved by: Alexander Belchenko
Approved revision: 1495
Merged at revision: 1496
Proposed branch: lp:~jayrod/qbzr/bug1030343
Merge into: lp:qbzr
Diff against target: 26 lines (+4/-1)
2 files modified
NEWS.txt (+3/-0)
lib/commit.py (+1/-1)
To merge this branch: bzr merge lp:~jayrod/qbzr/bug1030343
Reviewer Review Type Date Requested Status
Alexander Belchenko Approve
Review via email: mp+118038@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Alexander Belchenko (bialix) wrote :

Have you tested this fix?

You've put your news item in the middle of the existing section. That news section is related to already released version of qbzr. Please, move your news to upmost section releated to unreleased version of qbzr.

review: Needs Fixing
Revision history for this message
Alexander Belchenko (bialix) wrote :

OK, I saw your comments to bug about testing. That's OK for me. Thank you for your patch! I will update news while landing your patch.

review: Approve
Revision history for this message
Jared Silva (jayrod) wrote :

Sorry, I did not realize this was the first change in the next
release. Thanks for the help. My first patch on lp :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS.txt'
2--- NEWS.txt 2012-07-12 14:08:31 +0000
3+++ NEWS.txt 2012-08-03 05:19:24 +0000
4@@ -39,6 +39,9 @@
5 (Alexander Belchenko, Bug #878204)
6 * qbind:
7 * Add push location to suggestions. (Alexander Belchenko)
8+ * qcommit:
9+ * Better support of cancel commit for git branch.
10+ (Bug #1030343, Jared Silva, Jelmer Vernooij)
11 * qconflicts:
12 * Added 2 resolve actions to context menu: `Take "THIS"`
13 and `Take "OTHER"`. (Alexander Belchenko)
14
15=== modified file 'lib/commit.py'
16--- lib/commit.py 2012-04-12 04:49:37 +0000
17+++ lib/commit.py 2012-08-03 05:19:24 +0000
18@@ -600,7 +600,7 @@
19 self.bugsCheckBox.setChecked(True)
20
21 def save_commit_data(self):
22- if (self.tree.branch.control_files.get_physical_lock_status()
23+ if (self.tree.branch.get_physical_lock_status()
24 or self.tree.branch.is_locked()):
25 # XXX maybe show this in a GUI MessageBox (information box)???
26 from bzrlib.trace import warning

Subscribers

People subscribed via source and target branches