Merge lp:~jaypipes/nova/bug760289 into lp:~hudson-openstack/nova/trunk

Proposed by Jay Pipes
Status: Merged
Approved by: Soren Hansen
Approved revision: 988
Merged at revision: 988
Proposed branch: lp:~jaypipes/nova/bug760289
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 12 lines (+2/-1)
1 file modified
nova/image/glance.py (+2/-1)
To merge this branch: bzr merge lp:~jaypipes/nova/bug760289
Reviewer Review Type Date Requested Status
Thierry Carrez (community) Approve
Nova Core security contacts Pending
Review via email: mp+57609@code.launchpad.net

Description of the change

Rework GlanceImageService._translate_base() to not call BaseImageService._translate_base() otherwise the wrong class attributes are used in properties construction...

To post a comment you must log in.
Revision history for this message
Vish Ishaya (vishvananda) wrote :

Launchpad is down, but this fixes the issue for me and should definitely go in to cactus imo

Vish

On Apr 13, 2011, at 3:43 PM, Jay Pipes wrote:

> image_meta = service.BaseImageService._propertify_metadata(
> + image_meta, cls.SERVICE_IMAGE_ATTRS)

Revision history for this message
Thierry Carrez (ttx) wrote :

From Vish during the outage:
> Launchpad is down, but this fixes the issue for me and should definitely go in to cactus imo

review: Approve
Revision history for this message
Soren Hansen (soren) wrote :

lgtm, too.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/image/glance.py'
2--- nova/image/glance.py 2011-04-06 19:58:57 +0000
3+++ nova/image/glance.py 2011-04-13 22:42:33 +0000
4@@ -186,7 +186,8 @@
5 """Overriding the base translation to handle conversion to datetime
6 objects
7 """
8- image_meta = service.BaseImageService._translate_to_base(image_meta)
9+ image_meta = service.BaseImageService._propertify_metadata(
10+ image_meta, cls.SERVICE_IMAGE_ATTRS)
11 image_meta = _convert_timestamps_to_datetimes(image_meta)
12 return image_meta
13