lp:~jaypipes/glance/refactor-stores

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~hudson-openstack/glance/trunk at revision 173

Rick Harris (community): Approve on 2011-08-02

Jason Kölker (community): Approve on 2011-08-02

Brian Waldon (community): Approve on 2011-08-02

Diff: 1982 lines (+660/-508)

17 files modified

glance/api/v1/images.py (+11/-8)
glance/common/exception.py (+14/-0)
glance/store/__init__.py (+90/-48)
glance/store/base.py (+98/-0)
glance/store/filesystem.py (+65/-42)
glance/store/http.py (+34/-23)
glance/store/location.py (+2/-10)
glance/store/s3.py (+81/-74)
glance/store/scrubber.py (+5/-0)
glance/store/swift.py (+77/-72)
tests/functional/test_scrubber.py (+2/-2)
tests/stubs.py (+0/-66)
tests/unit/test_filesystem_store.py (+12/-12)
tests/unit/test_http_store.py (+63/-31)
tests/unit/test_s3_store.py (+44/-53)
tests/unit/test_store_location.py (+18/-14)
tests/unit/test_swift_store.py (+44/-53)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

179. By Jay Pipes on 2011-08-02

Remove expected_size stuff

178. By Jay Pipes on 2011-08-02

Make calling delete on a store that doesn't support it raise an exception, clean up stubout of HTTP store and testing of http store

177. By Jay Pipes on 2011-08-01

Add configuration check for Filesystem store on configure(), not every call to add()

176. By Jay Pipes on 2011-08-01

Refactor S3 store to make configuration one-time at init versus every method call invocation

175. By Jay Pipes on 2011-08-01

Refactor Swift store to make configuration one-time at init versus every method call invocation

174. By Jay Pipes on 2011-08-01

Forgot to add a new file...

173. By Jay Pipes on 2011-08-01

  Refactors stores to be stateful:

    * Creates a new base Store class
    * Adds code for new Store modules to "register" with Glance
    and ensure that when the Controller(s) are spun up, that
    the stateful store objects are all created properly and passed
    configuration options. This allows us to refactor a bunch of code
    out of the various store adapters that is constantly re-checking
    configuration option values during each call to get/add/delete, etc

    Work TODO:

    * Remove the now-unnecessary repetitve option-checking code in the
      Swift, S3, and filesystem drivers

172. By Justin Shepherd on 2011-07-31

Use of "%default" in help string does not work, have to use "%(default)s". Per the 4th example http://docs.python.org/dev/library/argparse.html#prog

171. By Justin Shepherd on 2011-07-31

Added nose-exclude to pip-requires.

'./run_tests.sh --unittests-only' adds '--exclude-dir=tests/functional' to noseargs.

170. By Jay Pipes on 2011-07-29

Completes the S3 storage backend. The original code did not actually fit
the API from boto it turned out, and the stubs that were in the unit test
were hiding this fact.

Adds a unit test that gets S3 testing up to snuff with the Swift backend.