lp:~jaypipes/drizzle/bugs

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~drizzle-trunk/drizzle/development

Brian Aker: Pending requested 2009-12-24

Drizzle Developers: Pending requested 2009-12-24

Diff: 129 lines (+23/-23)

2 files modified

drizzled/temporal_format.cc (+23/-22)
drizzled/temporal_format.h (+0/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #384531: compile failure centos 5.2	Critical	Fix Released
Bug #402831: Query Logging output missing a comma	Medium	Fix Released
Bug #402855: session->connect_utime doesn't appear to be populated	Medium	Fix Released
Bug #409711: plugin/command_log/command_log.cc can't be compiled on 32 bit platforms	Medium	Fix Released
Bug #434128: Build failure on debian	Critical	Fix Released
Bug #500031: dbt2 fails with 1024 connections	High	Fix Released

Link a bug report

Related blueprints

1253. By Jay Pipes <jpipes@serialcoder> on 2009-12-24

Fixes LP Bug #500031:

"dbt2 fails with 1024 connections"

After investigation into this, I discovered that there was a
race condition in TemporalFormat::match():

TemporalFormat::_re is the compiled PCRE regular expression object
inside each of the TemporalFormat objects, which are shared
among all threads and live in global scope.

Unfortunately, TemporalFormat::match() was using the member
variable TemporalFormat::_match_vector as its match state.
At high concurrency, this means that the following race
condition could happen:

Thread 1 executes pcre_exec() and finds a match, therefore
populating TemporalFormat::_match_vector of integers
with the position offsets of the matched pieces of the temporal object.

Thread 1, during construction of the Temporal output of
TemporalFormat::match(), uses these _match_vector position
offsets in calling std::string::substr on a copy of the
matched string, essentially "cutting up" the string
into year, month, day, etc.

Thread 2 executes pcre_exec() and also finds a match,
thereby changing TemporalFormat::_match_vector to something
different

Thread 1 continues trying to use std::string::substr(),
but now uses offsets that are invalid for its string,
thereby producing an out_of_range exception.

The solution is to pull the TemporalFormat::_match_vector
member variable and instead put a function-scope-level
match_vector variable on the stack inside TemporalFormat::match().

1252. By Brian Aker <brian@gaz> on 2009-12-23

Merge Jay

1251. By Brian Aker <brian@gaz> on 2009-12-21

Merging in massif option to test-run.pl

1250. By Brian Aker <brian@gaz> on 2009-12-21

Merge Monty

1249. By Brian Aker <brian@gaz> on 2009-12-21

Merge Valgrind.

1248. By Brian Aker <brian@gaz> on 2009-12-19

Merge from Dennis Schoen

1247. By Brian Aker <brian@gaz> on 2009-12-18

Merge from Padraig

1246. By Brian Aker <brian@gaz> on 2009-12-18

MErge Padraig

1245. By Brian Aker <brian@gaz> on 2009-12-18

Merge Jay

1244. By Brian Aker <brian@gaz> on 2009-12-18

Fixed from Monty.