Merge ~jawn-smith/software-properties:armhf_tests into software-properties:ubuntu/master

Proposed by William Wilson
Status: Merged
Merged at revision: e48cb1a2da03d11deefad61656293d6582e8a8d1
Proposed branch: ~jawn-smith/software-properties:armhf_tests
Merge into: software-properties:ubuntu/master
Diff against target: 31 lines (+7/-5)
2 files modified
debian/changelog (+7/-0)
debian/tests/run-tests (+0/-5)
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+398169@code.launchpad.net

Description of the change

While the testbed for armhf is unreliable, I don't think we should skip the tests altogether. If this is accepted we can add a hint for software-properties on armhf to retry the tests. Now that the add-apt-repository-ppa test with the massive for loop has been removed, the tests should be less flakey on armhf. I have tested on a local armhf machine and they are taking less than half the time than when the add-apt-repository-ppa test was included.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I've merged this as its not that the armhf test was unreliable rather that the software-properties autopkgtests (which were removed in the last upload) took a very long time on armhf.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index a346950..d57359b 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+software-properties (0.99.8) UNRELEASED; urgency=medium
7+
8+ * Enable tests for armhf. They should be more reliable now that the huge
9+ for loops have been removed.
10+
11+ -- William 'jawn-smith' Wilson <william.wilson@canonical.com> Tue, 16 Feb 2021 16:22:37 -0600
12+
13 software-properties (0.99.7) hirsute; urgency=medium
14
15 * Fix add-apt-repository operation (LP: #1913601)
16diff --git a/debian/tests/run-tests b/debian/tests/run-tests
17index eb7f191..b88a91f 100755
18--- a/debian/tests/run-tests
19+++ b/debian/tests/run-tests
20@@ -2,11 +2,6 @@
21
22 set -e
23
24-if dpkg-architecture -i armhf; then
25- # armhf testbed is totally unreliable, skip it
26- exit 77
27-fi
28-
29 tmpdir="$(mktemp -d)"
30 cleanup () {
31 rm -rf "$tmpdir"

Subscribers

People subscribed via source and target branches