Code review comment for lp:~javierder/bzr-eclipse/send_command

Hi

On Mon, Apr 20, 2009 at 9:26 PM, Javier Derderian <email address hidden> wrote:
>> Hi!
>>
>> I managed to get the copyright headers and added a SendOperation to make it
>> work as a Job.
>>
Great!

maybe missed to bzr add it? ;)

btw, The code looks ok.

Just one more thing, please remove the commented block on SendAction:

  /*final SendCommand cmd = new SendCommand(resourcesToSend[0],
dialog.getOptions(), new BranchLocation(dialog.getValue()));
  run(new WorkspaceModifyOperation() {
   public void execute(IProgressMonitor monitor) throws
InvocationTargetException {
    try {
     cmd.run(monitor);
    } catch (BazaarException e) {
     // FIXME: exception handling
     throw new InvocationTargetException(e);
    } finally {
     monitor.done();
    }
   }
  }, true / * cancelable * /, PROGRESS_DIALOG);*/

Thanks!

>> I'm working right now with the browse dialog, but if you think it's ok I'll
>> love to get this merged ASAP and then help you make a new release tomorrow
>> (maybe a intermedial version before 1.2.0? or some beta?)
>
>
> ok, browse button is there!!!!!!!!

Cool!

Cheers,

--
Guillermo Gonzalez
<http://launchpad.net/~verterok>