Merge lp:~javier.collado/utah/use_isinstance into lp:utah

[Javier Collado]

This is a small refactoring to use `isinstance` instead of `type` since it's
considered a good practice.

[Max Brustkern (nuclearbob)]

Looks reasonable to me. self.assertIsInstance(int(result), int) looks a little funny at first, but I guess if it fails to cast result to int, it'll raise an exception.

review: Approve

[Javier Collado (javier.collado)]

Yes, I guess that's only to make the test explicit. `int` raises a `ValueError`
exception in case of any problem.

I'm merging this now, but if Joe wants to update that to remove the assertion,
I can do that later.

=== modified file 'examples/run_utah_tests.py'
--- examples/run_utah_tests.py	2012-12-11 08:41:24 +0000
+++ examples/run_utah_tests.py	2012-12-12 11:31:27 +0000
@@ -130,7 +130,7 @@
 
 if __name__ == '__main__':
     try:
-        if type(config.jobtimeout) == int:
+        if isinstance(config.jobtimeout, int):
             try:
                 timeout(config.jobtimeout, run_utah_tests)
             except UTAHTimeout:

=== modified file 'utah/client/runner.py'
--- utah/client/runner.py	2012-12-08 02:10:12 +0000
+++ utah/client/runner.py	2012-12-12 11:31:27 +0000
@@ -397,7 +397,7 @@
 
         if 'testsuites' in data:
             suites = data['testsuites']
-        elif type(data) == list:
+        elif isinstance(data, list):
             suites = data
         else:
             raise exceptions.BadMasterRunlist(str(data))

=== modified file 'utah/client/tests/test_vcs_bzr.py'
--- utah/client/tests/test_vcs_bzr.py	2012-12-03 14:02:18 +0000
+++ utah/client/tests/test_vcs_bzr.py	2012-12-12 11:31:27 +0000
@@ -95,4 +95,4 @@
         result = bzr.get_revision(directory=path)
 
         shutil.rmtree(path)
-        self.assertEqual(type(int(result)), int)
+        self.assertIsInstance(int(result), int)

=== modified file 'utah/client/tests/test_vcs_dev.py'
--- utah/client/tests/test_vcs_dev.py	2012-12-03 14:02:18 +0000
+++ utah/client/tests/test_vcs_dev.py	2012-12-12 11:31:27 +0000
@@ -90,4 +90,4 @@
         result = dev.get_revision(directory=path)
 
         shutil.rmtree(path)
-        self.assertEqual(type(result), str)
+        self.assertIsInstance(result, str)

=== modified file 'utah/client/tests/test_vcs_git.py'
--- utah/client/tests/test_vcs_git.py	2012-12-03 14:02:18 +0000
+++ utah/client/tests/test_vcs_git.py	2012-12-12 11:31:27 +0000
@@ -93,4 +93,4 @@
         result = git.get_revision(directory=path)
 
         shutil.rmtree(path)
-        self.assertEqual(type(result), str)
+        self.assertIsInstance(result, str)