Merge lp:~javier.collado/utah/fix_client_examples into lp:utah

Proposed by Javier Collado
Status: Merged
Merged at revision: 631
Proposed branch: lp:~javier.collado/utah/fix_client_examples
Merge into: lp:utah
Diff against target: 34 lines (+2/-2)
3 files modified
utah/client/examples/utah_tests/test_one/tc_control (+1/-0)
utah/client/examples/utah_tests/test_two/tc_control (+1/-0)
utah/client/examples/utah_tests/tslist.run (+0/-2)
To merge this branch: bzr merge lp:~javier.collado/utah/fix_client_examples
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+119382@code.launchpad.net

Description of the change

The change to make the command field mandatory in the test case control file broke the examples under utah/client/examples.

This change moves each command from the the testsuite runlist to the tc_control files.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

I didn't notice that. I'll have to rewrite my existing test cases as well. Am I correct in assuming that putting the command in tc_control will still work with old versions of utah as well?

Revision history for this message
Javier Collado (javier.collado) wrote :

In didn't test the old version. What I can say is that, since there was no validation, the command was optional in both tc_control and tslist.run. Anyway, I think it should work because the runner logic in the client is still the same.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

All right. I'll update my test cases.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utah/client/examples/utah_tests/test_one/tc_control'
2--- utah/client/examples/utah_tests/test_one/tc_control 2012-04-18 21:55:48 +0000
3+++ utah/client/examples/utah_tests/test_one/tc_control 2012-08-13 16:30:46 +0000
4@@ -1,4 +1,5 @@
5 description: A first sample test case.
6+command: python test.one.py
7 dependencies: n/a
8 action: |
9 1. Action 1
10
11=== modified file 'utah/client/examples/utah_tests/test_two/tc_control'
12--- utah/client/examples/utah_tests/test_two/tc_control 2012-04-10 20:23:50 +0000
13+++ utah/client/examples/utah_tests/test_two/tc_control 2012-08-13 16:30:46 +0000
14@@ -1,4 +1,5 @@
15 description: A second sample test case.
16+command: python test_two.py
17 dependencies: n/a
18 action: |
19 1. Action 1
20
21=== modified file 'utah/client/examples/utah_tests/tslist.run'
22--- utah/client/examples/utah_tests/tslist.run 2012-08-08 21:10:05 +0000
23+++ utah/client/examples/utah_tests/tslist.run 2012-08-13 16:30:46 +0000
24@@ -1,10 +1,8 @@
25 - test: test_one
26- command: python test_one.py
27 run_as: nobody
28 overrides:
29 timeout: 3
30
31 - test: test_two
32- command: python test_two.py
33 overrides:
34 timeout: 300

Subscribers

People subscribed via source and target branches