Merge lp:~javier.collado/utah/documentation_fixes into lp:utah

Proposed by Javier Collado
Status: Merged
Approved by: Javier Collado
Approved revision: 865
Merged at revision: 863
Proposed branch: lp:~javier.collado/utah/documentation_fixes
Merge into: lp:utah
Diff against target: 61 lines (+8/-4)
3 files modified
utah/process.py (+3/-2)
utah/retry.py (+3/-0)
utah/run.py (+2/-2)
To merge this branch: bzr merge lp:~javier.collado/utah/documentation_fixes
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+159133@code.launchpad.net

Description of the change

Fixes for a few warnings that were printed while building the documentation.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good to me. Is there an easy way for me to check new code for these sorts of things? The version of pep257 I have didn't seem to pick them up.

review: Approve
Revision history for this message
Javier Collado (javier.collado) wrote :

Yes, the fixes in this branch are not really pep257 errors, but problems
related to reStructuredText and sphinx. What I've done with this is just build
the documentation and look at the output:

$ cd docs/
$ make html
sphinx-build -b html -d build/doctrees source build/html
Making output directory...
Running Sphinx v1.1.3
loading pickled environment... not yet created
building [html]: targets for 10 source files that are out of date
updating environment: 10 added, 0 changed, 0 removed
reading sources... [100%] reference
utah/dev/utah/process.py:docstring of utah.process.pid_in_use:7: WARNING: Field list ends without a blank line; unexpected unindent.
utah/dev/utah/retry.py:docstring of utah.retry.retry:16: ERROR: Unexpected indentation.
utah/dev/utah/run.py:docstring of utah.run.ReturnCodes:1: ERROR: Unknown target name: "run".
utah/dev/utah/run.py:docstring of utah.run.common_arguments:1: ERROR: Unknown target name: "run".
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] reference
writing additional files... (33 module code pages) _modules/index
 genindex py-modindex search
copying images... [100%] img/utah.jpg
copying static files... done
dumping search index... done
dumping object inventory... done
build succeeded, 4 warnings.

Build finished. The HTML pages are in build/html.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utah/process.py'
2--- utah/process.py 2013-04-10 15:42:26 +0000
3+++ utah/process.py 2013-04-16 11:36:26 +0000
4@@ -28,8 +28,9 @@
5 If arg_patterns is provided then the pid's command line will be compared
6 to make sure it matches an expected value.
7
8- :returns: proc object if the pid is active and optionally matches one of
9- the arg_patterns, otherwise None
10+ :returns:
11+ proc object if the pid is active and optionally matches one of the
12+ arg_patterns, otherwise None
13 :rtype: psutil.Process
14
15 """
16
17=== modified file 'utah/retry.py'
18--- utah/retry.py 2013-04-03 21:17:26 +0000
19+++ utah/retry.py 2013-04-16 11:36:26 +0000
20@@ -33,16 +33,19 @@
21 :param command: Command to be executed.
22 :type command: callable
23 :param args: Positional arguments to be passed to the callable.
24+ :type args: tuple
25 :param kwargs:
26 Keyword arguments to be passed to the callable.
27
28 .. note::
29 There are a few keywords that are consumed by ``retry`` and not
30 passed to the callable:
31+
32 * ``logmethod``: Preferred log method for every retry attempt
33 (``sys.stderr`` by default)
34 * ``retry_timeout``: Timeout in seconds between each retry
35 attempt
36+ :type kwargs: dict
37
38 :returns: The value returned by the callable.
39
40
41=== modified file 'utah/run.py'
42--- utah/run.py 2013-04-11 19:09:06 +0000
43+++ utah/run.py 2013-04-16 11:36:26 +0000
44@@ -38,7 +38,7 @@
45 # Return codes for the server
46 class ReturnCodes:
47
48- """Provide standard return codes for run_ scripts."""
49+ """Provide standard return codes for run\_ scripts."""
50
51 SUCCESS = 0 # No problems found
52 UTAH_EXCEPTION_ERROR = 1 # UTAH exception caught
53@@ -65,7 +65,7 @@
54
55
56 def common_arguments(parser):
57- """Centralize command line arguments for all run_ scripts.
58+ """Centralize command line arguments for all run\_ scripts.
59
60 :returns: argparse parser with arguments added
61 :rtype: obj

Subscribers

People subscribed via source and target branches