UTAH

Merge lp:~javier.collado/utah/bug1100203 into lp:utah

  1. bug1100203
  2. Merge into dev
Proposed by Javier Collado
Status: Merged
Approved by: Javier Collado
Approved revision: 800
Merged at revision: 800
Proposed branch: lp:~javier.collado/utah/bug1100203
Merge into: lp:utah
Diff against target: 11 lines (+1/-0)
1 file modified
utah/run.py (+1/-0)
To merge this branch: bzr merge lp:~javier.collado/utah/bug1100203
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+143486@code.launchpad.net

Description of the change

When the runlists argument was renamed to runlist and moved to the
common_arguments function, the url_argument type was dropped and that's what is
causing the bug now.

To fix this, `type=url_argument` is re-added to the command line argument.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

I'm surprised we didn't notice this as an issue before now. Thanks for the fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utah/run.py'
2--- utah/run.py 2013-01-10 18:26:55 +0000
3+++ utah/run.py 2013-01-16 11:43:23 +0000
4@@ -30,6 +30,7 @@
5
6 def common_arguments(parser):
7 parser.add_argument('runlist', metavar='runlist',
8+ type=url_argument,
9 help='URLs of runlist files to run')
10 parser.add_argument('-s', '--series', metavar='SERIES',
11 choices=config.serieschoices,

Subscribers

People subscribed via source and target branches