lp:~javier.collado/utah/bug1087620

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:utah at revision 788

Max Brustkern (community): Approve on 2012-12-12

Javier Collado (community): Needs Resubmitting on 2012-12-12

Diff: 274 lines (+83/-97)

2 files modified

utah/iso.py (+72/-61)
utah/isotest/iso_static_validation.py (+11/-36)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1087620: vmlinuz not found during server ISO validation

Critical

Fix Released

Link a bug report

Related blueprints

797. By Javier Collado on 2012-12-12

Added keyword arguments to subprocess.check_output call

796. By Javier Collado on 2012-12-12

Added seealso pointer in docstring

795. By Javier Collado on 2012-12-12

Updated `ISO.dump` docstring

794. By Javier Collado on 2012-12-12

Refactored `ISO.getrealfile` method

bsdtar error and output parsing error are handled in different try/except
clauses to provide better information in the log (parsing error message
contains the otuput from bsdtar)

793. By Javier Collado on 2012-12-12

Use "extract" in the error message for the bsdtar extract command

792. By Javier Collado on 2012-12-12

Refactored `ISO.dump` to check bsdtar return code and return just output file

791. By Javier Collado on 2012-12-12

Added check to make sure that bsdtar extract command returned a success code

`subprocess.check_output` is used instead of `subprocess.Popen`

790. By Javier Collado on 2012-12-12

Added check to make sure that bsdtar list command returned a success code

`subprocess.check_output` is used instead of `subprocess.Popen`

789. By Javier Collado on 2012-12-07

Updated static validation test cases

Since the signature of ISO.extract has changed, the test cases have to be
updated accordingly.

788. By Javier Collado on 2012-12-07

Refactored ISO.{getrealfile,extract} methods

Both metods were too complicated, so I decided to simplify them.

`getrealfile` the handling of links didn't seem to be used anywhere.

`extract` was inconsistent in its return time it returned the output
`subprocess.Popen` or the one from `subprocess.call`.