Merge lp:~javier.collado/utah/bug1068664 into lp:utah
Status: | Rejected |
---|---|
Rejected by: | Javier Collado |
Proposed branch: | lp:~javier.collado/utah/bug1068664 |
Merge into: | lp:utah |
Diff against target: |
79 lines (+19/-5) 3 files modified
utah/config.py (+1/-0) utah/provisioning/provisioning.py (+17/-4) utah/run.py (+1/-1) |
To merge this branch: | bzr merge lp:~javier.collado/utah/bug1068664 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Javier Collado (community) | Disapprove | ||
Joe Talbott (community) | Needs Information | ||
Review via email:
|
Description of the change
This branch changes the utah client command string to execute is as root as
it's required now.
Additional information:
- The way to use as root is to prepend "sudo -S".
- The -S tells sudo to read the password from stdin.
- SSHMixin.run takes care of writing the password to stdin when needed.
(basically when the paramiko channel is still open after running the command).
- A new configuration variable (config.password) is used to store the password value.
- Support to overwrite the password in the preseed has been added so that the
password in the preseed is in sync with the code.
Unmerged revisions
- 719. By Javier Collado
-
Changed username and passwd lines changed if any of them exists
The username and password lines in the preseed were changed only
if 'passwd/username' was present. Now, all of them are changed
just if any of the following is available:
- 'passwd/username'
- 'passwd/user-password'
- 'passwd/user-password- again' - 718. By Javier Collado
-
Renamed _rewrite_passwd as suggested by joetalbott
Final name is: _rewrite_
username_ and_passwd - 717. By Javier Collado
-
Added password rewritting to the preseed
Given that the previous commit adds a new password field to the configuration
file, this commit adds support to use that value in the preseed as well. - 716. By Javier Collado
-
Updated utah client command to use "sudo -S"
Additional information:
- This is needed because the client needs to be executed as root.
- The -S tells sudo to read the password from stdin.
- A new configuration variable `password` is used to get the password to be
used.
It seems to me that keeping the method name '_rewrite_ passwd_ username' is more descriptive since it's setting both the password and username.
Other than that looks good to me.