Merge lp:~javier.collado/utah/bug1039555-client into lp:~utah/utah/bug1039555

Proposed by Javier Collado
Status: Merged
Approved by: Max Brustkern
Approved revision: 663
Merged at revision: 660
Proposed branch: lp:~javier.collado/utah/bug1039555-client
Merge into: lp:~utah/utah/bug1039555
Diff against target: 144 lines (+47/-8)
8 files modified
Makefile (+5/-2)
client-Makefile (+5/-2)
client.py (+1/-1)
debian/control (+1/-1)
debian/utah-client.manpages (+1/-0)
docs/source/conf.py (+1/-1)
docs/source/man/utah.rst (+32/-0)
utah_howto.txt (+1/-1)
To merge this branch: bzr merge lp:~javier.collado/utah/bug1039555-client
Reviewer Review Type Date Requested Status
Javier Collado (community) Needs Resubmitting
Review via email: mp+120768@code.launchpad.net

Description of the change

This merge contains the changes needed to generate a man page for the client.

Note that the merge is against a branch owned by the team (lp:~utah/utah/bug1039555) to handle all the changes for this bug. Hence, this branch doesn't attempt to fix the whole bug, but just a part of it which is the generation of the man page for the client.

Remaining changes:
- Set final text for the `utah` man page
- Generate man pages for the server scripts
- Set the final text for the server scripts

Every set of changes is expected to be handled in a different branch to be merged also against lp:~utah/utah/bug1039555. Once everything is in that branch, the merge against lp:utah/dev will be proposed.

To post a comment you must log in.
662. By Javier Collado

Added python-sphinx as build dependency

Otherwise packaging while fail when trying to generate man pages.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I think "Ubuntu Automation Test Harness" should be "Ubuntu Test Automation Harness" or just "UTAH." UATH is the old version.

663. By Javier Collado

Fixed typo (uath -> utah)

Revision history for this message
Javier Collado (javier.collado) wrote :

@Max

Thanks, I copied client.py output without realizing about the type. Fixed it in the man page and in a couple of other places.

review: Needs Resubmitting
Revision history for this message
Javier Collado (javier.collado) wrote :

@Max

Let me know if you find some other issue. Otherwise, I'll merge this and continue the work on the man pages.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good to me. Merge away!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2012-08-14 16:42:41 +0000
3+++ Makefile 2012-08-22 16:44:18 +0000
4@@ -1,5 +1,5 @@
5 PYC_PATTERN?=*.pyc
6-all: client conf/utah/bootspeed-preseed.cfg conf/utah/bridged-network-vm.xml conf/utah/config
7+all: client conf/utah/bootspeed-preseed.cfg conf/utah/bridged-network-vm.xml conf/utah/config manpages
8
9 client:
10 [ -d "client" ] || mkdir client
11@@ -17,6 +17,9 @@
12 conf/utah/config:
13 ./utah/config.py > conf/utah/config
14
15+manpages:
16+ cd docs && make man
17+
18 clean:
19 find . -name "$(PYC_PATTERN)" -delete
20 rm -rf client
21@@ -26,4 +29,4 @@
22 rm -f utah_*
23 rm -f utah-*
24
25-.PHONY: client clean
26+.PHONY: client clean manpages
27
28=== modified file 'client-Makefile'
29--- client-Makefile 2012-05-21 14:05:50 +0000
30+++ client-Makefile 2012-08-22 16:44:18 +0000
31@@ -1,4 +1,4 @@
32-all: utah-client_fake_all.deb utah/config
33+all: utah-client_fake_all.deb utah/config manpages
34
35 utah-client_fake_all.deb:
36 touch utah-client_fake_all.deb
37@@ -6,7 +6,10 @@
38 utah/config:
39 touch utah/config
40
41+manpages:
42+ cd docs && make man
43+
44 clean:
45 rm utah/config
46
47-.PHONY: clean
48+.PHONY: clean manpages
49
50=== modified file 'client.py'
51--- client.py 2012-08-09 21:39:20 +0000
52+++ client.py 2012-08-22 16:44:18 +0000
53@@ -23,7 +23,7 @@
54 import argparse
55
56 parser = argparse.ArgumentParser(
57- description='Ubuntu Automation Testing Harness')
58+ description='Ubuntu Testing Automation Harness')
59 parser.add_argument('--resume', action='store_true',
60 help='Continue a previous run. Used after a reboot')
61 parser.add_argument('-s', '--state-file',
62
63=== modified file 'debian/control'
64--- debian/control 2012-08-14 16:55:16 +0000
65+++ debian/control 2012-08-22 16:44:18 +0000
66@@ -3,7 +3,7 @@
67 X-Python-Version: >= 2.5
68 Priority: optional
69 Maintainer: Max Brustkern <max@canonical.com>
70-Build-Depends: debhelper (>= 7.0.50~), python-all, devscripts
71+Build-Depends: debhelper (>= 7.0.50~), devscripts, python-all, python-sphinx
72 Standards-Version: 3.9.3
73 Homepage: https://code.launchpad.net/utah
74 Vcs-Bzr: https://code.launchpad.net/utah
75
76=== added file 'debian/utah-client.manpages'
77--- debian/utah-client.manpages 1970-01-01 00:00:00 +0000
78+++ debian/utah-client.manpages 2012-08-22 16:44:18 +0000
79@@ -0,0 +1,1 @@
80+docs/build/man/utah.1
81
82=== modified file 'docs/source/conf.py'
83--- docs/source/conf.py 2012-08-20 11:33:46 +0000
84+++ docs/source/conf.py 2012-08-22 16:44:18 +0000
85@@ -230,7 +230,7 @@
86 # One entry per manual page. List of tuples
87 # (source start file, name, description, authors, manual section).
88 man_pages = [
89- ('index', 'utah', u'UTAH Documentation',
90+ ('man/utah', 'utah', u'Ubuntu Test Automation Harness',
91 [u'Canonical Ltd'], 1)
92 ]
93
94
95=== added directory 'docs/source/man'
96=== added file 'docs/source/man/utah.rst'
97--- docs/source/man/utah.rst 1970-01-01 00:00:00 +0000
98+++ docs/source/man/utah.rst 2012-08-22 16:44:18 +0000
99@@ -0,0 +1,32 @@
100+:orphan:
101+
102+utah manual page
103+================
104+
105+Synopsis
106+--------
107+
108+utah [-h] [--resume] [-s STATE_FILE] [-f {text,yaml,json}] [-t TESTDIR] [-r RUNLIST] [-o OUTPUT] [-a] [-d]
109+
110+Description
111+-----------
112+
113+:program:`utah` executes a runlist and generates a file with the results
114+
115+Options
116+-------
117+-h, --help show this help message and exit
118+--resume Continue a previous run. Used after a reboot
119+-s STATE_FILE, --state-file STATE_FILE
120+ File to use for storing state (default
121+ "/var/lib/utah/state.yaml"
122+-f <text,yaml,json>, --format <text,yaml,json>
123+ Output format (default "yaml")
124+-t TESTDIR, --testdir TESTDIR
125+ Main test directory
126+-r RUNLIST, --runlist RUNLIST
127+ runlist file name
128+-o OUTPUT, --output OUTPUT
129+ write output to this file
130+-a, --append append to output
131+-d, --debug Print debugging output
132
133=== modified file 'utah_howto.txt'
134--- utah_howto.txt 2012-08-02 14:18:50 +0000
135+++ utah_howto.txt 2012-08-22 16:44:18 +0000
136@@ -60,7 +60,7 @@
137 usage: utah [-h] [--resume] [-s STATE_FILE] [-f {text,yaml}] [-t TESTDIR]
138 [-r RUNLIST] [-o OUTPUT] [-a] [-d]
139
140-Ubuntu Automation Testing Harness
141+Ubuntu Testing Automation Harness
142
143 optional arguments:
144 -h, --help show this help message and exit

Subscribers

People subscribed via source and target branches

to all changes: