Merge lp:~javier.collado/utah/bug1024364 into lp:utah

[Javier Collado]

Added a few checks to make sure that neither virtualbox nor vmware are running.

The checks are based in looking at the command line of running processes. They're not 100% accurate, but they should be fine for now.

[Max Brustkern (nuclearbob)]

Your note says TBD: Run this only if provisioning a KVM. Would it make sense to move the check into the VM provisioning classes, specifically, VMToolsVM and CustomVM, and have them raise an exception if they are trying to provision a KVM? I think VMToolsVM always tries to provision a kvm (I'm not exactly sure, since that class uses an external command for provision) and I know that in CustomKVM as part of __init__, we pick an emulator if we weren't passed one, so we know then whether we're going to try qemu or kvm. I think having this in the provisioning classes would let us leverage it in future scripts.

That being said, this implementation is fine, so if you think it's better off this way, we can go with this, and it does have the advantage of already being written.

Also, at some point, I'd like to get run_test_vm and run_install_tests changed so that they share code better, but that's not really relevant to this, I just keep noticing how you have to duplicate code in these merges, so I'd like to fix that.

[lp:~javier.collado/utah/bug1024364]

426. By Javier Collado on 2012-07-17

Moved process checking code to utah.provisioning.vm.libvirtvm.CustomVM

427. By Javier Collado on 2012-07-17

Refactored code to an object oriented design

[Javier Collado (javier.collado)]

I've followed your advice and now I think the code looks cleaner.

review: Needs Resubmitting

[Max Brustkern (nuclearbob)]

This looks good. Do we need to check for other emulators when we're running qemu, or just kvm? If we don't need that check for qemu, we can move it down to after we check the emulator, and only check if it's kvm. Either way, I'll go ahead and do the merge, it's definitely an improvement on what we have now.

review: Approve

[Javier Collado (javier.collado)]

How do I force utah to use qemu without kvm? Should I set target architecture to arm?

[Max Brustkern (nuclearbob)]

When running run_utah_tests.py or run_install_test.py, pass -e qemu.

=== modified file 'debian/control'
--- debian/control	2012-07-13 15:10:47 +0000
+++ debian/control	2012-07-17 09:20:23 +0000
@@ -10,7 +10,7 @@
 
 Package: utah
 Architecture: all
-Depends: ${misc:Depends}, ${python:Depends}, python-libvirt, python-apt, python-yaml, libvirt-bin, bzr, git, bsdtar, lzma
+Depends: ${misc:Depends}, ${python:Depends}, python-libvirt, python-apt, python-yaml, python-psutil, libvirt-bin, bzr, git, bsdtar, lzma
 Recommends: kvm, vm-tools
 Provides: utah-client, ubuntu-automation-test-harness, ubuntu-automation-test-harness-client
 Conflicts: utah-client, ubuntu-automation-test-harness, ubuntu-automation-test-harness-client

=== added file 'utah/process.py'
--- utah/process.py	1970-01-01 00:00:00 +0000
+++ utah/process.py	2012-07-17 09:20:23 +0000
@@ -0,0 +1,30 @@
+"""
+Process checking utilities
+"""
+import psutil
+
+
+class ProcessChecker(object):
+    """
+    Check all running process looking for a given pattern
+    """
+    MESSAGE_TEMPLATE = \
+            ("{app} application is running.\n"
+            "Please stop it before launching utah since "
+            "it won't interact properly with KVM "
+            "(Kernel-based Virtual Machine)\n")
+
+    def check_cmdline(self, pattern):
+        """
+        Check if the command line of any process matches the given pattern
+        """
+        pids = psutil.get_pid_list()
+        processes = (psutil.Process(pid) for pid in pids)
+        cmdlines = (' '.join(process.cmdline) for process in processes)
+        return any(pattern in cmdline for cmdline in cmdlines)
+
+    def get_error_message(self, app):
+        """
+        Return error message for an incompatible application process running
+        """
+        return self.MESSAGE_TEMPLATE.format(app=app)

=== modified file 'utah/provisioning/vm/libvirtvm.py'
--- utah/provisioning/vm/libvirtvm.py	2012-07-16 21:50:15 +0000
+++ utah/provisioning/vm/libvirtvm.py	2012-07-17 09:20:23 +0000
@@ -16,6 +16,7 @@
 from utah.provisioning import *
 from utah.provisioning.vm import *
 from utah import config
+from utah.process import ProcessChecker
 
 class LibvirtVM(VM):
     """
@@ -267,6 +268,14 @@
 
 class CustomVM(CustomInstallMixin, SSHMixin, LibvirtVM):
     def __init__(self, arch=None, boot=None, disksizes=None, emulator=None, image=None, initrd=None, installtype=None, kernel=None, machineid=None, macs=[], name=None, prefix='utah', preseed=None, series=None, xml=None, *args, **kw):
+        # Make sure that no other virtualization solutions are running
+        process_checker = ProcessChecker()
+        for cmdline, app in [('/usr/lib/virtualbox/VirtualBox', 'VirtualBox'),
+                             ('/usr/lib/vmware/bin', 'VMware')]:
+            if process_checker.check_cmdline(cmdline):
+                message = process_checker.get_error_message(app)
+                raise UTAHVMProvisioningException(message)
+
         if disksizes is None:
             self.disksizes = [8]
         else: