selenium-simple-test

Merge lp:~javier.collado/selenium-simple-test/yahoo_finance_search into lp:selenium-simple-test

  1. yahoo_finance_search
  2. Merge into trunk
Proposed by Javier Collado
Status: Merged
Approved by: Leo Arias
Approved revision: 436
Merged at revision: 436
Proposed branch: lp:~javier.collado/selenium-simple-test/yahoo_finance_search
Merge into: lp:selenium-simple-test
Diff against target: 12 lines (+1/-1)
1 file modified
examples/yahoofinance.py (+1/-1)
To merge this branch: bzr merge lp:~javier.collado/selenium-simple-test/yahoo_finance_search
Reviewer Review Type Date Requested Status
Leo Arias (community) code review Approve
Review via email: mp+189617@code.launchpad.net

Description of the change

While reading the documentation and running the examples, I found that title
for the yahoo finance search web is no longer "Yahoo!", but "Yahoo finance
search". Hence, I've updated the test accordingly to make it pass.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

Great, thanks Javier!
I've reported bug #1236889, because we should be running this scripts with the rest of the tests to avoid this on the future.

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/yahoofinance.py'
2--- examples/yahoofinance.py 2012-02-23 16:13:41 +0000
3+++ examples/yahoofinance.py 2013-10-07 14:23:19 +0000
4@@ -2,7 +2,7 @@
5
6
7 go_to('http://finance.search.yahoo.com/')
8-assert_title_contains('Yahoo!')
9+assert_title_contains('Yahoo Finance Search')
10 element = get_element(id='yschsp')
11 write_textfield(element, 'AMZN', clear=False)
12 click_button('yschbt')

Subscribers

People subscribed via source and target branches