Merge lp:~javier.collado/content-hub/bug1274899 into lp:content-hub

Proposed by Javier Collado
Status: Merged
Approved by: Ken VanDine
Approved revision: 74
Merged at revision: 81
Proposed branch: lp:~javier.collado/content-hub/bug1274899
Merge into: lp:content-hub
Diff against target: 56 lines (+52/-0)
1 file modified
README (+52/-0)
To merge this branch: bzr merge lp:~javier.collado/content-hub/bug1274899
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Leo Arias (community) Approve
PS Jenkins bot continuous-integration Approve
Javier Collado (community) Needs Resubmitting
Review via email: mp+204208@code.launchpad.net

Commit message

Added README file

Description of the change

This branch adds a README file to the branch with the basic information about
he project.

To post a comment you must log in.
73. By Javier Collado

Fixed typo

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:72
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~javier.collado/content-hub/bug1274899/+merge/204208/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/content-hub-ci/105/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-trusty-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-trusty-armhf-ci/8
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-trusty-armhf-ci/8/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-trusty-i386-ci/8

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/content-hub-ci/105/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:73
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~javier.collado/content-hub/bug1274899/+merge/204208/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/content-hub-ci/106/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-trusty-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-trusty-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-trusty-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-trusty-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/content-hub-ci/106/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

A couple minor changes.

It would be better to build out of tree

mkdir build
cd build
cmake ..
make

Also for running the tests, I'd recommend running them with dbus-test-runner so they don't interfere with the users dbus session.

cd build/tests
dbus-test-runner -t make -p test

review: Needs Fixing
74. By Javier Collado

Added suggestions from Ken

Revision history for this message
Javier Collado (javier.collado) wrote :

The last change should address all your suggestions. Please let me know if
that's not the case.

review: Needs Resubmitting
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

I followed the steps, everything works as expected. Thanks Javier.

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Excellent, thanks!

review: Approve
Revision history for this message
Javier Collado (javier.collado) wrote :

Ken, should this get merged automatically? If that's not the case, then please
apply the merge since I don't have permissions to push to lp:content-hub.
Thanks.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * No code change, just added a README file.

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * The checklist wasn't filled out, this branch was approved before we changed the landing process. I have ensured all the steps were successful.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'README'
2--- README 1970-01-01 00:00:00 +0000
3+++ README 2014-02-12 16:53:02 +0000
4@@ -0,0 +1,52 @@
5+What is content-hub?
6+--------------------
7+
8+content-hub is a mediation service to let applications share content between
9+them even if they are not running at the same time.
10+
11+For a more detailed description, please have a look at:
12+doc/Mainpage.md
13+
14+
15+How do I get all building dependencies?
16+---------------------------------------
17+
18+Build dependencies are already listed in the debian/control file. To get them
19+use the following command:
20+sudo apt-get build-dep content-hub
21+
22+
23+How do I compile the code?
24+--------------------------
25+
26+To compile the code run the following command from the branch directory:
27+mkdir build
28+cd build
29+cmake ..
30+make
31+
32+
33+How do I run the test cases?
34+----------------------------
35+
36+To run the test cases use the following command:
37+cd build/tests
38+dbus-test-runner -t make -p test
39+
40+
41+How do I build the packages?
42+----------------------------
43+
44+To build the pacakges run the following command:
45+bzr builddeb
46+
47+
48+How do I install the code?
49+--------------------------
50+
51+One way to do it one the code is compiled is:
52+make install
53+
54+However, the recommended way to do it is by installing the packages built
55+manually.
56+

Subscribers

People subscribed via source and target branches