Merge lp:~javier.collado/checkbox/fix_disk_read_performance_name into lp:checkbox

Proposed by Javier Collado
Status: Merged
Merged at revision: 1266
Proposed branch: lp:~javier.collado/checkbox/fix_disk_read_performance_name
Merge into: lp:checkbox
Diff against target: 12 lines (+1/-1)
1 file modified
jobs/disk.txt.in (+1/-1)
To merge this branch: bzr merge lp:~javier.collado/checkbox/fix_disk_read_performance_name
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+93419@code.launchpad.net

Description of the change

In the whitelists used for testing I see the following pattern:
disk/read_performance_sd\w

However, in the disk/read_performance job, I see the jobs being created like this:
disk_read_performance_`ls /sys$path/block`

This change, just modifies the name pattern above to:
disk/read_performance_`ls /sys$path/block`

to be consistent with other test names and to make the whitelists select a job that pattern that exists.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

Awesome, good catch!

review: Approve
Revision history for this message
Marc Tardif (cr3) wrote :

However, we now need a bug and a changelog entry. I'll take care of those for your convenience

Revision history for this message
Javier Collado (javier.collado) wrote :

Thanks for opening the bug Marc.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jobs/disk.txt.in'
2--- jobs/disk.txt.in 2012-02-03 20:12:54 +0000
3+++ jobs/disk.txt.in 2012-02-16 14:56:23 +0000
4@@ -72,7 +72,7 @@
5 command:
6 cat <<'EOF' | run_templates -t -s 'udev_resource | filter_templates -w "category=DISK"'
7 plugin: shell
8- name: disk_read_performance_`ls /sys$path/block`
9+ name: disk/read_performance_`ls /sys$path/block`
10 requires:
11 device.path == "$path"
12 package.name == 'linux'

Subscribers

People subscribed via source and target branches