Merge lp:~javier.collado/checkbox/bug931954 into lp:checkbox

[Javier Collado]

This change:

- removes "miscellanea/check_and_install_ipmitool" job that installs "ipmitool" package
- removes "miscellanea/check_and_install_ipmitool" dependency in "miscellanea/ipmi_test"
- adds "ipmitool" package requirement in "miscellanea/ipmi_test"

[Marc Tardif (cr3)]

There seems to be a spurious line in the changelog but I'll fix that when merging. Otherwise, looks good and I'll review the corresponding merge request in checkbox-certification. Thanks!

=== modified file 'debian/changelog'
--- debian/changelog	2012-02-10 17:54:25 +0000
+++ debian/changelog	2012-02-14 14:06:11 +0000
@@ -1,5 +1,6 @@
 checkbox (0.13.2) precise; urgency=low
 
+  [ Daniel Manrique ]
   [Jeff Lane]
   * Added a Hard Disk Stats Test that was part of a much older merge request
     for server test suite.
@@ -25,7 +26,10 @@
     prettified tabs and updated Launchpad email text amongst other UI tweaks
     in qt/frontend/qtfront.ui
 
- -- Daniel Manrique <[e-mail]>  Mon, 06 Feb 2012 14:55:58 -0500
+  [ Javier Collado ]
+  * Removed job that installed ipmitool by default (LP: #931954)
+
+ -- Javier Collado <[e-mail]>  Tue, 14 Feb 2012 10:26:54 +0100
 
 checkbox (0.13.1) precise; urgency=low
 

=== modified file 'jobs/miscellanea.txt.in'
--- jobs/miscellanea.txt.in	2012-02-03 21:29:06 +0000
+++ jobs/miscellanea.txt.in	2012-02-14 14:06:11 +0000
@@ -23,15 +23,9 @@
 command:
  fwts_test -l $CHECKBOX_DATA/fwts_results.log
 
-plugin: local
-name: miscellanea/check_and_install_ipmitool
-user: root
-command: dpkg -l | grep -iq 'ipmitool' || apt-get install -y ipmitool >/dev/null 2>&1
-_description: ipmitool is required for ipmi testing. This checks for ipmitool and installs it if not available.
-
 plugin: shell
 name: miscellanea/ipmi_test
-depends: miscellanea/check_and_install_ipmitool
+requires: package.name == 'ipmitool'
 user: root
 command: ipmi_test
 _description: