Merge lp:~javier.collado/checkbox/bug888447 into lp:checkbox

Proposed by Javier Collado
Status: Merged
Merged at revision: 1115
Proposed branch: lp:~javier.collado/checkbox/bug888447
Merge into: lp:checkbox
Diff against target: 125 lines (+30/-8)
7 files modified
.checkbox-editor.cfg (+18/-0)
debian/changelog (+5/-1)
jobs/graphics.txt.in (+1/-1)
jobs/info.txt.in (+2/-2)
jobs/peripheral.txt.in (+1/-1)
jobs/suspend.txt.in (+2/-2)
jobs/user_apps.txt.in (+1/-1)
To merge this branch: bzr merge lp:~javier.collado/checkbox/bug888447
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Review via email: mp+81819@code.launchpad.net

Description of the change

This branch fixes the broken dependencies described in bug888447

It also adds a checkbox-editor configuration file, so that checkbox-editor can be used to verify that dependencies are now fixed.

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Hey Javier,

Thanks for this! Merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '.checkbox-editor.cfg'
2--- .checkbox-editor.cfg 1970-01-01 00:00:00 +0000
3+++ .checkbox-editor.cfg 2011-11-10 09:09:30 +0000
4@@ -0,0 +1,18 @@
5+[environment]
6+checkbox_share = .
7+
8+[version control]
9+push_branch = lp:checkbox
10+pull_branch = lp:checkbox
11+push_on_close = False
12+commit_on_save = False
13+pull_on_open = False
14+exclude = .checkbox-editor.cfg
15+
16+[general]
17+checkbox_data_cleanup = True
18+replace_tabs_with_spaces = True
19+number_of_spaces = 4
20+checkbox_binary = ./bin/checkbox-gtk
21+whitelist_resources = True
22+
23
24=== modified file 'debian/changelog'
25--- debian/changelog 2011-11-09 20:00:45 +0000
26+++ debian/changelog 2011-11-10 09:09:30 +0000
27@@ -1,5 +1,6 @@
28 checkbox (0.13) precise; urgency=low
29
30+ [ Daniel Manrique ]
31 [Marc Tardif]
32 * Generate a submission.xml file that contains all device and attachment
33 information, suitable for offline processing and submission.
34@@ -36,7 +37,10 @@
35 BLUETOOTH to run, thus preventing the test from failing on systems with
36 no Bluetooth device (LP: #862322)
37
38- -- Daniel Manrique <daniel.manrique@canonical.com> Fri, 04 Nov 2011 16:32:08 -0400
39+ [ Javier Collado ]
40+ * Broken job dependencies fixed (LP: #888447)
41+
42+ -- Javier Collado <javier.collado@canonical.com> Thu, 10 Nov 2011 10:05:04 +0100
43
44 checkbox (0.12.8) oneiric; urgency=low
45
46
47=== modified file 'jobs/graphics.txt.in'
48--- jobs/graphics.txt.in 2011-10-07 18:59:33 +0000
49+++ jobs/graphics.txt.in 2011-11-10 09:09:30 +0000
50@@ -124,7 +124,7 @@
51 plugin: manual
52 name: graphics/cycle_resolution
53 requires: package.name == 'xorg'
54-depends: xrandr_detect_modes
55+depends: graphics/xrandr_detect_modes
56 command: xrandr_cycle
57 _description:
58 PURPOSE:
59
60=== modified file 'jobs/info.txt.in'
61--- jobs/info.txt.in 2011-10-14 10:30:52 +0000
62+++ jobs/info.txt.in 2011-11-10 09:09:30 +0000
63@@ -86,13 +86,13 @@
64
65 plugin: attachment
66 name: info/screenshot.png
67-depends: screenshot
68+depends: info/screenshot
69 command: cat ${CHECKBOX_DATA}/screenshot.png
70 _description: Attaches the screenshot captured in info/screenshot.
71
72 plugin: attachment
73 name: info/fwts_log
74-depends: fwts_test
75+depends: miscellanea/fwts_test
76 _description: Gather log from the Firmware Test Suite run.
77 command:
78 cat $CHECKBOX_DATA/fwts_results.log
79
80=== modified file 'jobs/peripheral.txt.in'
81--- jobs/peripheral.txt.in 2011-10-07 18:59:33 +0000
82+++ jobs/peripheral.txt.in 2011-11-10 09:09:30 +0000
83@@ -32,7 +32,7 @@
84
85 plugin: shell
86 name: peripheral/external-usb-modem-http
87-depends: external-usb-modem
88+depends: peripheral/external-usb-modem
89 command: wget -SO /dev/null http://$TRANSFER_SERVER
90 _description:
91 Automated test case to make sure that it's possible to download files through HTTP
92
93=== modified file 'jobs/suspend.txt.in'
94--- jobs/suspend.txt.in 2011-10-07 18:59:33 +0000
95+++ jobs/suspend.txt.in 2011-11-10 09:09:30 +0000
96@@ -28,7 +28,7 @@
97
98 plugin: shell
99 name: suspend/wireless_before_suspend
100-depends: networking/wireless_connection
101+depends: wireless/wireless_connection
102 command: nmcli -t -f UUID con status > $CHECKBOX_DATA/connections && connect_wireless && internet_test --interface=`nmcli dev list | grep -B 1 wireless | grep GENERAL.DEVICE | awk '{print $2}'` && for con in `cat $CHECKBOX_DATA/connections`; do nmcli con up uuid "$con"; done
103 _description:
104 This test disconnects all connections and then connects to the wireless
105@@ -56,7 +56,7 @@
106
107 plugin: manual
108 name: suspend/suspend_advanced
109-depends: power-management/rtc networking/detect suspend/resolution_before_suspend suspend/wireless_before_suspend bluetooth/detect-output suspend/bluetooth_mouse_before_suspend suspend/cpu_before_suspend suspend/memory_before_suspend
110+depends: power-management/rtc networking/detect suspend/resolution_before_suspend suspend/wireless_before_suspend bluetooth/detect-output suspend/cpu_before_suspend suspend/memory_before_suspend
111 requires: package.name == 'pm-utils'
112 user: root
113 command: sleep_test -d
114
115=== modified file 'jobs/user_apps.txt.in'
116--- jobs/user_apps.txt.in 2011-10-07 18:59:33 +0000
117+++ jobs/user_apps.txt.in 2011-11-10 09:09:30 +0000
118@@ -1,6 +1,6 @@
119 plugin: manual
120 name: software/update_manager_finds_updates
121-depends: internet_test
122+depends: networking/detect
123 user: root
124 requires: package.name == 'update-manager'
125 _description:

Subscribers

People subscribed via source and target branches