Merge lp:~javier.collado/checkbox/bug597305 into lp:checkbox

Proposed by Javier Collado on 2010-06-22
Status: Rejected
Rejected by: Marc Tardif on 2010-09-14
Proposed branch: lp:~javier.collado/checkbox/bug597305
Merge into: lp:checkbox
Diff against target: 12 lines (+1/-1)
1 file modified
scripts/udev_resource (+1/-1)
To merge this branch: bzr merge lp:~javier.collado/checkbox/bug597305
Reviewer Review Type Date Requested Status
Javier Collado (community) Disapprove on 2010-07-20
Marc Tardif (community) 2010-06-22 Needs Information on 2010-07-20
Review via email: mp+28199@code.launchpad.net

Description of the change

/sbin directory added to path so that udevadm command can be found even if /sbin isn't in the PATH environment variable.

To post a comment you must log in.
Marc Tardif (cr3) wrote :

Under which circumstance does this happen?

review: Needs Information
Javier Collado (javier.collado) wrote :

I have seen a report in which this happened as explained in bug597305. However, I don't really know why PATH doesn't contain /sbin directory. Anyway, I believe this isn't mandatory and checkbox shouldn't rely on it. Do you agree?

Javier Collado (javier.collado) wrote :

@Marc,

Any update on this?

Marc Tardif (cr3) wrote :

I'd like to understand under what circumstances /sbin is not in the PATH variable before adding it to the environment.

review: Needs Information
Javier Collado (javier.collado) wrote :

Since I'm not able to reproduce the problem I'll reject the merge proposal and mark the bug as 'Won't fix'.

If I find the same problem in the future I'll try to gather the required information.

review: Disapprove

Unmerged revisions

823. By Javier Collado on 2010-06-22

Adding /sbin path to udevadm command

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/udev_resource'
2--- scripts/udev_resource 2010-04-22 21:12:51 +0000
3+++ scripts/udev_resource 2010-06-22 15:32:29 +0000
4@@ -34,7 +34,7 @@
5
6
7 # Command to retrieve udev information.
8-COMMAND = "udevadm info --export-db"
9+COMMAND = "/sbin/udevadm info --export-db"
10
11
12 class DeviceResource(object):

Subscribers

People subscribed via source and target branches