Merge lp:~jassmith/window-picker-applet/double-click-title into lp:window-picker-applet

Proposed by Jason Smith
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jassmith/window-picker-applet/double-click-title
Merge into: lp:window-picker-applet
Diff against target: None lines
To merge this branch: bzr merge lp:~jassmith/window-picker-applet/double-click-title
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Review via email: mp+10735@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :

implements unmaximize on double click title

Revision history for this message
Neil J. Patel (njpatel) wrote :

I like it...looks nice with Dust. Approve.

review: Approve
Revision history for this message
Neil J. Patel (njpatel) wrote :

> I like it...looks nice with Dust. Approve.

Bah, added comment to the wrong review, sorry :)

This is also approved :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/task-title.c'
2--- src/task-title.c 2009-08-21 09:12:47 +0000
3+++ src/task-title.c 2009-08-26 13:03:41 +0000
4@@ -334,17 +334,27 @@
5
6 window = wnck_screen_get_active_window (priv->screen);
7
8- if (event->button != 3)
9- return FALSE;
10-
11- if (!WNCK_IS_WINDOW (window)
12- || wnck_window_get_window_type (window) == WNCK_WINDOW_DESKTOP)
13- return FALSE;
14-
15- menu = wnck_action_menu_new (window);
16- gtk_menu_popup (GTK_MENU (menu), NULL, NULL, NULL, NULL,
17- event->button, event->time);
18- return TRUE;
19+ g_return_val_if_fail (WNCK_IS_WINDOW (window), FALSE);
20+
21+ if (event->button == 3)
22+ {
23+ if (wnck_window_get_window_type (window) != WNCK_WINDOW_DESKTOP)
24+ {
25+ menu = wnck_action_menu_new (window);
26+ gtk_menu_popup (GTK_MENU (menu), NULL, NULL, NULL, NULL,
27+ event->button, event->time);
28+ return TRUE;
29+ }
30+ }
31+ else if (event->button == 1)
32+ {
33+ if (event->type == GDK_2BUTTON_PRESS && wnck_window_is_maximized (window))
34+ {
35+ wnck_window_unmaximize (window);
36+ }
37+ }
38+
39+ return FALSE;
40 }
41
42

Subscribers

People subscribed via source and target branches

to all changes: