Merge lp:~jassmith/window-picker-applet/atk into lp:window-picker-applet

[Jason Smith]

[Jason Smith (jassmith)]

Adds screen reader support to all buttons

[lp:~jassmith/window-picker-applet/atk]

92. By Jason Smith <jason@t500> on 2009-08-26

Set atk object role to button

[Mirco Müller (macslow)]

Are the descriptions strings not meant to be translated? Just wondering here in general. I don't know the must-have features of window-picker.

review: Needs Information

[lp:~jassmith/window-picker-applet/atk]

93. By Jason Smith <jason@t500> on 2009-08-26

Translatable strings

[Jason Smith (jassmith)]

> Are the descriptions strings not meant to be translated? Just wondering here
> in general. I don't know the must-have features of window-picker.

Fixed, sorry, always forget to do that...

[David Barth (dbarth)]

Mirco Müller wrote:
> Review: Needs Information
> Are the descriptions strings not meant to be translated? Just wondering here in general. I don't know the must-have features of window-picker.
>
Can you compare your patch against this commit of notify-osd, where
Eitan added support for ATK. I'm not an expert either, but it seems he
had to add whole objects to implement that. How is your patch different,
ie what is the feature(s) gap between the two?

David

[Jason Smith (jassmith)]

> Mirco Müller wrote:
> > Review: Needs Information
> > Are the descriptions strings not meant to be translated? Just wondering here
> in general. I don't know the must-have features of window-picker.
> >
> Can you compare your patch against this commit of notify-osd, where
> Eitan added support for ATK. I'm not an expert either, but it seems he
> had to add whole objects to implement that. How is your patch different,
> ie what is the feature(s) gap between the two?
>
> David

I looked at the way this is done in notify OSD and it looks to me as it implements in this fashion due to notify OSD being one giant custom widget. The method I implemented is from the ATK example documentation for simpler cases (ours is not a completely custom widget really).

Jason

[David Barth (dbarth)]

OK, the changes are sound and based on the ATK tutorial. It's mostly to set some attributes and the rest of the lifecycle for the atk bits is already managed by the /standard/ widgets.

review: Approve

[Jason Smith (jassmith)]

> OK, the changes are sound and based on the ATK tutorial. It's mostly to set
> some attributes and the rest of the lifecycle for the atk bits is already
> managed by the /standard/ widgets.

Pushed :)

=== modified file 'src/task-item.c'
--- src/task-item.c	2009-08-25 19:11:59 +0000
+++ src/task-item.c	2009-08-26 13:37:13 +0000
@@ -561,6 +561,27 @@
 }
 
 static void
+task_item_setup_atk (TaskItem *item)
+{
+  TaskItemPrivate *priv;
+  GtkWidget *widget;
+  AtkObject *atk;
+  WnckWindow *window;
+  
+  g_return_if_fail (TASK_IS_ITEM (item));
+  
+  widget = GTK_WIDGET (item);
+  priv = item->priv;
+  window = priv->window;
+  
+  g_return_if_fail (WNCK_IS_WINDOW (window));
+  
+  atk = gtk_widget_get_accessible (widget);
+  atk_object_set_name (atk, "Window Task Button");
+  atk_object_set_description (atk, wnck_window_get_name (window));
+}
+
+static void
 task_item_finalize (GObject *object)
 {
   TaskItemPrivate *priv;
@@ -667,6 +688,7 @@
                     G_CALLBACK (on_leave_notify), item);
                     
   task_item_set_visibility (task);
+  task_item_setup_atk (task);
   
   return item;
 }

=== modified file 'src/task-title.c'
--- src/task-title.c	2009-08-26 13:09:08 +0000
+++ src/task-title.c	2009-08-26 13:51:24 +0000
@@ -401,6 +401,7 @@
   GtkIconTheme *theme;
   GtkSettings *settings;
   GdkPixbuf *pixbuf;
+  AtkObject *atk;
   int width, height;
     	
   priv = title->priv = TASK_TITLE_GET_PRIVATE (title);
@@ -445,6 +446,10 @@
   gtk_box_pack_start (GTK_BOX (priv->box), priv->button, FALSE, FALSE, 0);
   gtk_widget_show (priv->button);
   
+  atk = gtk_widget_get_accessible (priv->button);
+  atk_object_set_name (atk, "Close");
+  atk_object_set_description (atk, "Close current window.");
+  
   g_signal_connect (priv->button, "button-release-event", 
                     G_CALLBACK (on_close_clicked), title);
   g_signal_connect (priv->button, "enter-notify-event",