Merge lp:~jassmith/unity/unity.alt-tab-workspaces into lp:unity

[Jason Smith]

Code correctness fix.
Fixes potential multi-monitor issue with alt-tab getting settings confused.

= Problem description =

We passed an int into a function expecting a bool. This caused the switcher to confuse its settings and act weirdly.

= The fix =

We pass a bool now.

= Test coverage =

Existing tests cover a degree of this behavior. Currently testing does not cover multi-monitor behavior however (which is where this bug showed up). The fix is obvious and the current code is clearly and demonstrably wrong, to the point of passing the wrong type into a function.

[Jason Smith (jassmith)]

Needs testing

review: Needs Fixing

[Tim Penhey (thumper)]

Again a manual test describing the expected behaviour should be sufficient.

In what situation with multiple monitors was this getting broken?

review: Needs Information

=== modified file 'plugins/unityshell/src/unityshell.cpp'
--- plugins/unityshell/src/unityshell.cpp	2012-02-18 11:47:22 +0000
+++ plugins/unityshell/src/unityshell.cpp	2012-02-22 07:46:18 +0000
@@ -1601,9 +1601,7 @@
 
   RaiseInputWindows();
 
-  int show_monitor = (show_mode == switcher::ShowMode::CURRENT_VIEWPORT) ? device : -1;
-
-  auto results = launcher_controller_->GetAltTabIcons(show_monitor);
+  auto results = launcher_controller_->GetAltTabIcons(show_mode == switcher::ShowMode::CURRENT_VIEWPORT);
 
   if (!(results.size() == 1 && results[0]->GetIconType() == AbstractLauncherIcon::IconType::TYPE_BEGIN))
     switcher_controller_->Show(show_mode, switcher::SortMode::FOCUS_ORDER, false, results);