Merge lp:~jassmith/unity/unity.alt-tab-timings into lp:unity

[Jason Smith]

= The Problem =
Alt-Tab timeouts are too long

= The Fix =
Make the timeout 75ms instead of 150ms

= Testing =
The existing switcher autopilot tests cover the expected behaviour alt-tab behaviour.

[Jason Smith (jassmith)]

No tests

review: Needs Fixing

[Didier Roche-Tolomelli (didrocks)]

configuration option change doesn't need tests. However, some autopilot test triggering the timeout would need to exist or be updated to this value.

[David Barth (dbarth)]

At the limit, a unit test could be added to verify that the defined default is what is actually the value that is used. There are practical maintenance issues to adding unit tests at that granularity, since the defaults are not managed in a configuration file, but in a design specification that is not programmatically connected to the code.

Besides, while arguing about the interest of an equivalent AP test, we have agreed that an AP test would be equivalent to such a unit test.

So we concluded that the AP test was not necessary, since the equivalent unit test would be rather trivial and difficult to maintain

review: Approve

[Tim Penhey (thumper)]

Jason, it could be worthwhile updating the switcher AP test to just wait for 0.1 sec.

=== modified file 'plugins/unityshell/src/SwitcherController.cpp'
--- plugins/unityshell/src/SwitcherController.cpp	2012-02-12 10:43:11 +0000
+++ plugins/unityshell/src/SwitcherController.cpp	2012-02-22 10:28:22 +0000
@@ -42,7 +42,7 @@
   ,  show_timer_(0)
   ,  detail_timer_(0)
 {
-  timeout_length = 150;
+  timeout_length = 75;
   detail_on_timeout = true;
   detail_timeout_length = 1500;
   monitor_ = 0;