Unity

Merge lp:~jassmith/unity/fix-coverflow-crash into lp:unity

  1. fix-coverflow-crash
  2. Merge into trunk
Proposed by Jason Smith
Status: Merged
Approved by: Neil J. Patel
Approved revision: no longer in the source branch.
Merged at revision: 2617
Proposed branch: lp:~jassmith/unity/fix-coverflow-crash
Merge into: lp:unity
Diff against target: 20 lines (+2/-1)
1 file modified
dash/CoverflowResultView.cpp (+2/-1)
To merge this branch: bzr merge lp:~jassmith/unity/fix-coverflow-crash
Reviewer Review Type Date Requested Status
Neil J. Patel Pending
Review via email: mp+121009@code.launchpad.net

Commit message

Fix bug #1039959

Description of the change

Fixes https://bugs.launchpad.net/unity/+bug/1039959

To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks and works great!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/CoverflowResultView.cpp'
2--- dash/CoverflowResultView.cpp 2012-08-20 19:50:52 +0000
3+++ dash/CoverflowResultView.cpp 2012-08-23 14:43:20 +0000
4@@ -85,6 +85,7 @@
5 static const int element_size = style.GetTileHeight();
6
7 icon_texture_ = new IconTexture(icon_name.c_str(), element_size, true);
8+ icon_texture_->SinkReference();
9 icon_texture_->LoadIcon();
10
11 icon_texture_->texture_updated.connect([&] (nux::BaseTexture *texture)
12@@ -96,7 +97,7 @@
13
14 CoverflowResultItem::~CoverflowResultItem()
15 {
16-
17+ icon_texture_->UnReference();
18 }
19
20 std::string CoverflowResultItem::Uri()