Merge lp:~jassmith/desktop-switcher/no-maximize into lp:desktop-switcher

Proposed by Jason Smith
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jassmith/desktop-switcher/no-maximize
Merge into: lp:desktop-switcher
Diff against target: None lines
To merge this branch: bzr merge lp:~jassmith/desktop-switcher/no-maximize
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
David Barth (community) Abstain
Review via email: mp+10967@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :
Revision history for this message
David Barth (dbarth) wrote :

The code seems ok, but i'd like Neil to confirm it's the only thing required to fix this bug.

review: Abstain
Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks good, as per bug. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/main.c'
2--- src/main.c 2009-08-17 11:14:08 +0000
3+++ src/main.c 2009-09-01 10:00:21 +0000
4@@ -52,6 +52,7 @@
5 #define NAUTILUS_SHOW_DESKTOP "/apps/nautilus/preferences/show_desktop"
6 #define THEME "/desktop/gnome/interface/gtk_theme"
7 #define MAXIMUS "/apps/maximus/undecorate"
8+#define MAXIMUS_NO_MAXIMIZE "/apps/maximus/no_maximize"
9
10 #define GCONF_STOP "gconftool-2 --shutdown"
11 #define GCONF_UNSET "gconftool-2 --recursive-unset /apps/panel"
12@@ -394,6 +395,17 @@
13 g_error_free (error);
14 error = NULL;
15 }
16+
17+ /* Set maximus no_maximize */
18+ error = NULL;
19+ gconf_client_set_bool (client, MAXIMUS_NO_MAXIMIZE, FALSE, &error);
20+ if (error)
21+ {
22+ g_warning ("Can't change Maximus's no maximize setting: %s",
23+ error->message);
24+ g_error_free (error);
25+ error = NULL;
26+ }
27
28 /* Launch the launcher */
29 g_debug ("Launching the, er, Launcher");
30@@ -511,6 +523,17 @@
31 g_error_free (error);
32 error = NULL;
33 }
34+
35+ /* Set maximus no_maximize */
36+ error = NULL;
37+ gconf_client_set_bool (client, MAXIMUS_NO_MAXIMIZE, TRUE, &error);
38+ if (error)
39+ {
40+ g_warning ("Can't change Maximus's no maximize setting: %s",
41+ error->message);
42+ g_error_free (error);
43+ error = NULL;
44+ }
45
46 /* Kill any version of the launcher. */
47 g_debug ("Killing the launcher");

Subscribers

People subscribed via source and target branches

to all changes: