cloud-init

Merge ~jasonzio/cloud-init:fixcloudid into cloud-init:master

  1. Git
  2. lp:~jasonzio/cloud-init
  3. fixcloudid
  4. Merge into master
Proposed by Jason Zions
Status: Merged
Approved by: Chad Smith
Approved revision: af4e9cbb3fd88a016e9e0bc560c09232a523fa2a
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~jasonzio/cloud-init:fixcloudid
Merge into: cloud-init:master
Diff against target: 24 lines (+2/-0)
2 files modified
packages/redhat/cloud-init.spec.in (+1/-0)
packages/suse/cloud-init.spec.in (+1/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Chad Smith Approve
Review via email: mp+357668@code.launchpad.net

Commit message

Add cloud-id binary to packages for SUSE

Description of the change

Fixes bug lp:1799337

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

@Jason,
Thank you for finding this.

You're probably right about the redhat also, and we would like that fixed.

Could you fix packages/redhat/cloud-init.spec.in also ?

Thanks again.

Revision history for this message
Scott Moser (smoser) wrote :

Hi,
Thank you for contributing to cloud-init.

To contribute, you must sign the Canonical Contributor License Agreement (CLA) [1].

If you have already signed it as an individual, your Launchpad user will be listed in the contributor-agreement-canonical launchpad group [2]. Unfortunately there is no easy way to check if an organization or company you are doing work for has signed. If you are unsure or have questions, email <email address hidden> or ping smoser in #cloud-init channel via freenode.

For information on how to sign, please see the HACKING document [3].

Thanks again, and please feel free to reach out with any questions.

–
[1] http://www.canonical.com/contributors
[2] https://launchpad.net/~contributor-agreement-canonical/+members
[3] http://cloudinit.readthedocs.io/en/latest/topics/hacking.html

~jasonzio/cloud-init:fixcloudid updated
af4e9cb... by Jason Zions <email address hidden>

Add cloud-id binary for redhat packages as well

Revision history for this message
Jason Zions (jasonzio) wrote :

I added the same change for RedHat packaging, per reviewer's request.

Revision history for this message
Jason Zions (jasonzio) wrote :

Also, I am a Microsoft employee, and to the best of my knowledge, Microsoft signed a corporate CLA.

Revision history for this message
Chad Smith (chad.smith) wrote :

Thanks for this changeset Jason and for the follow through. LGTM!

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/packages/redhat/cloud-init.spec.in b/packages/redhat/cloud-init.spec.in
2index a3a6d1e..6b2022b 100644
3--- a/packages/redhat/cloud-init.spec.in
4+++ b/packages/redhat/cloud-init.spec.in
5@@ -191,6 +191,7 @@ fi
6
7 # Program binaries
8 %{_bindir}/cloud-init*
9+%{_bindir}/cloud-id*
10
11 # Docs
12 %doc LICENSE ChangeLog TODO.rst requirements.txt
13diff --git a/packages/suse/cloud-init.spec.in b/packages/suse/cloud-init.spec.in
14index e781d74..26894b3 100644
15--- a/packages/suse/cloud-init.spec.in
16+++ b/packages/suse/cloud-init.spec.in
17@@ -93,6 +93,7 @@ version_pys=$(cd "%{buildroot}" && find . -name version.py -type f)
18
19 # Program binaries
20 %{_bindir}/cloud-init*
21+%{_bindir}/cloud-id*
22
23 # systemd files
24 /usr/lib/systemd/system-generators/*

Subscribers

People subscribed via source and target branches