Merge ~jasonlo/snappy-hwe-snaps/+git/jenkins-jobs:merge into ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master

Proposed by lo
Status: Needs review
Proposed branch: ~jasonlo/snappy-hwe-snaps/+git/jenkins-jobs:merge
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/jenkins-jobs:master
Diff against target: 32 lines (+6/-6)
2 files modified
jobs/image/image-build-worker.sh (+4/-4)
jobs/image/image-build-worker.yaml (+2/-2)
Reviewer Review Type Date Requested Status
Simon Fels Approve
Jim Hodapp (community) Approve
System Enablement Bot continuous-integration Approve
Konrad ZapaƂowicz Pending
Review via email: mp+329436@code.launchpad.net

Description of the change

1. Verify image-builds to become image-build without S.
2. Add --build-id=$BUILD_ID into build script.

We need <jenkins build id> as image index. Since in Hohhot we use a Makefile to create the image, this parameter should be passed into the Makefile to create the right naming.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Information
e5bbe3b... by lo

Change archive files to be img and bin in image build worker.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Can you add to the MR description what you need the build-id for?

Revision history for this message
lo (jasonlo) wrote :

> Can you add to the MR description what you need the build-id for?

According to CE Image Builds
https://docs.google.com/document/d/1zoebLPlBym5DAbHFJgr7geCyqxNheSazMEueSfHcxFQ/edit#
Image name: <project>-<version>-<type>-<grade>-<date>-<jenkins build id>-<partition>.img

We need <jenkins build id> as image index. Since in Hohhot we use Makefile to create the image, this parameter should be pass to Makefile to create the right naming.

212d6d0... by lo

Build script using Jenkins env BUILD_ID or given a default value 0.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve
Revision history for this message
Simon Fels (morphis) :
review: Approve
Revision history for this message
Jim Hodapp (jhodapp) wrote :

@Jason: ready for top approval of this? Also, make sure to check Simon's comment inline below.

Revision history for this message
lo (jasonlo) :

Unmerged commits

212d6d0... by lo

Build script using Jenkins env BUILD_ID or given a default value 0.

e5bbe3b... by lo

Change archive files to be img and bin in image build worker.

a3593b9... by lo

Verify image-builds to become image-build, and add build-id parameter in build.sh.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jobs/image/image-build-worker.sh b/jobs/image/image-build-worker.sh
2index c6cd784..ba5e646 100644
3--- a/jobs/image/image-build-worker.sh
4+++ b/jobs/image/image-build-worker.sh
5@@ -18,8 +18,8 @@ set -ex
6
7 . "$WORKSPACE/.build_env"
8
9-rm -rf "$WORKSPACE"/image-builds
10-git clone git+ssh://git.launchpad.net/~$LAUNCHPAD_TEAM/$LAUNCHPAD_PROJECT/+git/image-builds
11-cd image-builds
12+rm -rf "$WORKSPACE"/image-build
13+git clone git+ssh://git.launchpad.net/~$LAUNCHPAD_TEAM/$LAUNCHPAD_PROJECT/+git/image-build
14+cd image-build
15
16-./build.sh --output-dir=$WORKSPACE
17+exec ./build.sh --output-dir=$WORKSPACE
18diff --git a/jobs/image/image-build-worker.yaml b/jobs/image/image-build-worker.yaml
19index 4a39425..90dbed6 100644
20--- a/jobs/image/image-build-worker.yaml
21+++ b/jobs/image/image-build-worker.yaml
22@@ -15,7 +15,7 @@
23 - image-build-worker.sh
24 publishers:
25 - archive:
26- artifacts: '{image_artifacts}'
27+ artifacts: '*img*, *bin*'
28 allow-empty: 'true'
29 fingerprint: true
30- default-excludes: false
31\ No newline at end of file
32+ default-excludes: false

Subscribers

People subscribed via source and target branches

to all changes: