Merge lp:~jason-koelker/nova/lp762047 into lp:~hudson-openstack/nova/trunk

Proposed by Jason Kölker
Status: Merged
Approved by: Vish Ishaya
Approved revision: 993
Merged at revision: 1002
Proposed branch: lp:~jason-koelker/nova/lp762047
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 101 lines (+8/-14)
6 files modified
nova/api/openstack/contrib/volumes.py (+1/-2)
nova/image/fake.py (+1/-2)
nova/tests/api/openstack/test_image_metadata.py (+2/-4)
nova/tests/api/openstack/test_server_metadata.py (+1/-2)
nova/tests/api/openstack/test_versions.py (+2/-4)
nova/virt/vmwareapi/vim.py (+1/-0)
To merge this branch: bzr merge lp:~jason-koelker/nova/lp762047
Reviewer Review Type Date Requested Status
Vish Ishaya (community) Approve
Josh Kearney (community) Approve
Review via email: mp+57941@code.launchpad.net

Commit message

pep8 fixes

To post a comment you must log in.
Revision history for this message
Josh Kearney (jk0) wrote :

lgtm

review: Approve
Revision history for this message
Jason Kölker (jason-koelker) wrote :

I had to rewite the history on this branch to remove the unicode characters from my name.

lp:~jason-koelker/nova/lp762047 updated
993. By Jason Kölker

pep8 fixes

Revision history for this message
Vish Ishaya (vishvananda) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/api/openstack/contrib/volumes.py'
2--- nova/api/openstack/contrib/volumes.py 2011-03-30 00:22:20 +0000
3+++ nova/api/openstack/contrib/volumes.py 2011-04-18 20:51:44 +0000
4@@ -322,8 +322,7 @@
5 # Does this matter?
6 res = extensions.ResourceExtension('volumes',
7 VolumeController(),
8- collection_actions={'detail': 'GET'}
9- )
10+ collection_actions={'detail': 'GET'})
11 resources.append(res)
12
13 res = extensions.ResourceExtension('volume_attachments',
14
15=== modified file 'nova/image/fake.py'
16--- nova/image/fake.py 2011-03-30 19:34:10 +0000
17+++ nova/image/fake.py 2011-04-18 20:51:44 +0000
18@@ -47,8 +47,7 @@
19 'container_format': 'ami',
20 'disk_format': 'raw',
21 'properties': {'kernel_id': FLAGS.null_kernel,
22- 'ramdisk_id': FLAGS.null_kernel}
23- }
24+ 'ramdisk_id': FLAGS.null_kernel}}
25 self.create(None, image)
26 super(FakeImageService, self).__init__()
27
28
29=== modified file 'nova/tests/api/openstack/test_image_metadata.py'
30--- nova/tests/api/openstack/test_image_metadata.py 2011-04-08 07:58:48 +0000
31+++ nova/tests/api/openstack/test_image_metadata.py 2011-04-18 20:51:44 +0000
32@@ -46,8 +46,7 @@
33 'deleted_at': None,
34 'properties': {
35 'key1': 'value1',
36- 'key2': 'value2'
37- },
38+ 'key2': 'value2'},
39 'size': 5882349},
40 {'status': 'active',
41 'name': 'image2',
42@@ -62,8 +61,7 @@
43 'deleted_at': None,
44 'properties': {
45 'key1': 'value1',
46- 'key2': 'value2'
47- },
48+ 'key2': 'value2'},
49 'size': 5882349},
50 {'status': 'active',
51 'name': 'image3',
52
53=== modified file 'nova/tests/api/openstack/test_server_metadata.py'
54--- nova/tests/api/openstack/test_server_metadata.py 2011-03-24 17:52:20 +0000
55+++ nova/tests/api/openstack/test_server_metadata.py 2011-04-18 20:51:44 +0000
56@@ -48,8 +48,7 @@
57 "key2": "value2",
58 "key3": "value3",
59 "key4": "value4",
60- "key5": "value5"
61- }
62+ "key5": "value5"}
63 return metadata
64
65
66
67=== modified file 'nova/tests/api/openstack/test_versions.py'
68--- nova/tests/api/openstack/test_versions.py 2011-03-29 16:04:43 +0000
69+++ nova/tests/api/openstack/test_versions.py 2011-04-18 20:51:44 +0000
70@@ -47,8 +47,7 @@
71 {
72 "rel": "self",
73 "href": "http://localhost/v1.1",
74- }
75- ],
76+ }],
77 },
78 {
79 "id": "v1.0",
80@@ -57,8 +56,7 @@
81 {
82 "rel": "self",
83 "href": "http://localhost/v1.0",
84- }
85- ],
86+ }],
87 },
88 ]
89 self.assertEqual(versions, expected)
90
91=== modified file 'nova/virt/vmwareapi/vim.py'
92--- nova/virt/vmwareapi/vim.py 2011-03-31 21:19:59 +0000
93+++ nova/virt/vmwareapi/vim.py 2011-04-18 20:51:44 +0000
94@@ -43,6 +43,7 @@
95
96
97 if suds:
98+
99 class VIMMessagePlugin(suds.plugin.MessagePlugin):
100
101 def addAttributeForValue(self, node):